New issue
Advanced search Search tips

Issue 674455 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add video_JpegDecodeAccelerator autotest

Project Member Reported by wuchengli@chromium.org, Dec 15 2016

Issue description

jpeg_decode_accelerator_unittest.cc should be tested as often as vda unittest and vea unittest. We should add an ChromeOS autotest to run it.
 
Owner: jcliang@chromium.org
Status: Assigned (was: Available)
Ricky. Now that JPEG HW decode is getting much more important because camera resolution will increase a lot next year. Can you help with this? This autotest will be similiar to video_VideoEncodeAccelerator or video_VideoDecodeAccelerator.
FWIW, we currently have video_ChromeRTCHWDecodeUsed that verifies hw jpeg decode is enabled when playing a MJPEG video. The test checks the histogram to make sure that chrome does initialize hw jpeg decoder when playing the video. It won't catch the case where hw jpeg decode is successfully initialized but the actual decode fails. 
Status: Started (was: Assigned)
CLs uploaded: https://chromium-review.googlesource.com/q/topic:jda_autotest
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f93587e973f747f0b32c603556a5f290e9ce70

commit 09f93587e973f747f0b32c603556a5f290e9ce70
Author: jcliang <jcliang@chromium.org>
Date: Wed Dec 21 04:16:55 2016

media/gpu: Fix jpeg_decode_accelerator_unittest

This patch fixes compilation error in jpeg_decode_accelerator_unittest.
Also stops the unit test from generating core dumps when an invalid
command-line argument is given.

BUG= 674455 
TEST=Build and run jpeg_decode_accelerator_unittest on my DUT.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2585973002
Cr-Commit-Position: refs/heads/master@{#440012}

[modify] https://crrev.com/09f93587e973f747f0b32c603556a5f290e9ce70/media/gpu/jpeg_decode_accelerator_unittest.cc

Now we need to wait until chromeos-chrome is uprev'ed to pick up the fix in #4, and then we can merge the autotest CLs.
The fix for jda unittest is included in chrome 57.0.2959.0, which the chrome-pfq builders are building right now: https://uberchromegw.corp.google.com/i/chromeos/builders/master-chromium-pfq/builds/3760
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f1a9fe51b459cdf6174f76f2ed134de1f53fb10e

commit f1a9fe51b459cdf6174f76f2ed134de1f53fb10e
Author: Ricky Liang <jcliang@chromium.org>
Date: Thu Dec 15 16:31:47 2016

autotest-chrome, chromeos-chrome: add video_JpegDecodeAccelerator test

BUG= chromium:674455 
CQ-DEPEND=CL:420585
TEST=Run `emerge-<board> chromeos-chrome` then
     `test_that <dut> video_JpegDecodeAccelerator`

Change-Id: Ica4d202ba27aa42d4f7a38e55ffc9cf3f7523fe0
Reviewed-on: https://chromium-review.googlesource.com/420209
Commit-Ready: Ricky Liang <jcliang@chromium.org>
Tested-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/f1a9fe51b459cdf6174f76f2ed134de1f53fb10e/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
[modify] https://crrev.com/f1a9fe51b459cdf6174f76f2ed134de1f53fb10e/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/40a7d23601d5a0339e5cb6016420e952ba76852e

commit 40a7d23601d5a0339e5cb6016420e952ba76852e
Author: Ricky Liang <jcliang@chromium.org>
Date: Thu Dec 15 16:34:24 2016

Add video_JpegDecodeAccelerator test

The video_JpegDecodeAccelerator is a wrapper which runs the Chrome
jpeg_decode_accelerator_unittest to test the hardware JPEG decoder.

BUG= chromium:674455 
CQ-DEPEND=CL:420209
TEST=test_that <dut> video_JpegDecodeAccelerator

Change-Id: Iff287d561e49251d86149e3fe3b85265f786d8dc
Reviewed-on: https://chromium-review.googlesource.com/420585
Commit-Ready: Ricky Liang <jcliang@chromium.org>
Tested-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>

[add] https://crrev.com/40a7d23601d5a0339e5cb6016420e952ba76852e/client/site_tests/video_JpegDecodeAccelerator/control
[add] https://crrev.com/40a7d23601d5a0339e5cb6016420e952ba76852e/client/site_tests/video_JpegDecodeAccelerator/video_JpegDecodeAccelerator.py

Status: Fixed (was: Started)

Sign in to add a comment