New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674451 link

Starred by 1 user
Status: Fixed
Owner:
steve...@chromium.org
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Focus highlight appears small in chrome://md-settings/languages.

Reported by mni...@etouch.net, Dec 15 2016 
Version: 57.0.2952.0 199daadb512fd39c2c8c3e56f536acb7eb941fb4-refs/heads/master@{#438707} (64-bit)
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/languages and click on drop down arrow,observe the focus highlight

Actual: Focus highlight appears small
Expected: Focus highlight should be seen properly

This is regression issue, broken in ‘M 57’ and will soon update other info :
Good build:57.0.2950.0
Bad build: 57.0.2951.0
Actual_video.mov
2.5 MB Download
Expected_video.mov
2.4 MB Download

Comment 1 by msrchandra@chromium.org, Dec 15 2016

Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2950.0 (Revision: 438011).
Bad build: 57.0.2951.0 (Revision: 438385).

You are probably looking for a change made after 438342 (known good), but no later than 438343 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/506491c05a0dd41bc68604c9b34fe56d93705017..24b0822f45566f2d7bc2740a148a381582cc566a

@tevenjb -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if that is not the case.

Thank You.

Comment 2 by msrchandra@chromium.org, Dec 15 2016

Labels: -ReleaseBlock-Stable
Apologies for adding Blocker label. Removing it.
Thank You.

Comment 3 by steve...@chromium.org, Dec 15 2016 

This was an intentional change, but I will check with UX as to whether the side effect of a smaller focus highlight is desired.

Comment 4 by steve...@chromium.org, Dec 16 2016

Status: Started (was: Assigned)
Spoke with UX, I'm going to go ahead and fix this.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3d36ba882ca4a8c55a8be080d672abd83d5bea

commit 3b3d36ba882ca4a8c55a8be080d672abd83d5bea
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Dec 19 20:01:28 2016

MD Settings: Fix size and padding of expand button

This CL includes some cleanup to make the vars used for icon padding
consistent between cr_elements and settings UI.

BUG= 674451 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2578793004
Cr-Commit-Position: refs/heads/master@{#439531}

[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/controls/extension_controlled_indicator.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/shared_style_css.html
[modify] https://crrev.com/3b3d36ba882ca4a8c55a8be080d672abd83d5bea/ui/webui/resources/cr_elements/shared_vars_css.html

Comment 6 by steve...@chromium.org, Dec 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment