New issue
Advanced search Search tips

Issue 674448 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 644915



Sign in to add a comment

Migrate V8 off gnumbd

Project Member Reported by tandrii@chromium.org, Dec 15 2016

Issue description

Part of go/git-numberer.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0fb9b16b48fae4a398ec350ce6847ecb273af8b6

commit 0fb9b16b48fae4a398ec350ce6847ecb273af8b6
Author: tandrii <tandrii@chromium.org>
Date: Thu Dec 15 09:09:44 2016

Whitspace.

TBR=machenbach@chromium.org
NOTRY=True
NOPERSUBMIT=True
BUG= chromium:674448 

Review-Url: https://codereview.chromium.org/2582443003
Cr-Commit-Position: refs/heads/master@{#41707}

[modify] https://crrev.com/0fb9b16b48fae4a398ec350ce6847ecb273af8b6/tools/whitespace.txt

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/afbba3706dbda16218a2bcaf53206e6d7aa23d20

commit afbba3706dbda16218a2bcaf53206e6d7aa23d20
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Dec 15 09:48:56 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ff154c69f606372997832f7c5d4a0943257df341

commit ff154c69f606372997832f7c5d4a0943257df341
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Dec 15 10:05:47 2016

Whitespace change to test gnumbd shutdown - uploaded

BUG= chromium:674448 
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2580743004 .
Cr-Commit-Position: refs/heads/master@{#41709}

[modify] https://crrev.com/ff154c69f606372997832f7c5d4a0943257df341/tools/whitespace.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/47f8979d12543f814eddad990544447d4f95053c

commit 47f8979d12543f814eddad990544447d4f95053c
Author: machenbach <machenbach@chromium.org>
Date: Thu Dec 15 10:09:24 2016

Whitespace change to test gnumbd shutdown - CQ

BUG= chromium:674448 
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2579733002
Cr-Commit-Position: refs/heads/master@{#41710}

[modify] https://crrev.com/47f8979d12543f814eddad990544447d4f95053c/tools/whitespace.txt

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/49fe922ffa4499d68bb91f37ad899be83850ad00

commit 49fe922ffa4499d68bb91f37ad899be83850ad00
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Dec 15 10:05:06 2016

Fix git_footers to accept refs with periods in them.

For example, v8 has refs/heads/1.4.2

TBR=machenbach@chromium.org
BUG= chromium:674448 

Change-Id: Ia3405ee402a01153fc9744457d8fee9385446cae
Reviewed-on: https://chromium-review.googlesource.com/420285
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/49fe922ffa4499d68bb91f37ad899be83850ad00/git_footers.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4619fbe42a91de67abe4f794cf67274035776d84

commit 4619fbe42a91de67abe4f794cf67274035776d84
Author: machenbach <machenbach@chromium.org>
Date: Thu Dec 15 10:10:58 2016

Revert of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2579733002/ )

Reason for revert:
Test revert

Original issue's description:
> Whitespace change to test gnumbd shutdown - CQ
>
> BUG= chromium:674448 
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> TBR=tandrii@chromium.org
>
> Review-Url: https://codereview.chromium.org/2579733002
> Cr-Commit-Position: refs/heads/master@{#41710}
> Committed: https://chromium.googlesource.com/v8/v8/+/47f8979d12543f814eddad990544447d4f95053c

TBR=tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:674448 

Review-Url: https://codereview.chromium.org/2583443002
Cr-Commit-Position: refs/heads/master@{#41711}

[modify] https://crrev.com/4619fbe42a91de67abe4f794cf67274035776d84/tools/whitespace.txt

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b02fd88d75c44c0e88fd083076512c82a5f78adb

commit b02fd88d75c44c0e88fd083076512c82a5f78adb
Author: machenbach <machenbach@chromium.org>
Date: Thu Dec 15 10:12:18 2016

Reland of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2583443002/ )

Reason for revert:
Test reland

Original issue's description:
> Revert of Whitespace change to test gnumbd shutdown - CQ (patchset #1 id:1 of https://codereview.chromium.org/2579733002/ )
>
> Reason for revert:
> Test revert
>
> Original issue's description:
> > Whitespace change to test gnumbd shutdown - CQ
> >
> > BUG= chromium:674448 
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > TBR=tandrii@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2579733002
> > Cr-Commit-Position: refs/heads/master@{#41710}
> > Committed: https://chromium.googlesource.com/v8/v8/+/47f8979d12543f814eddad990544447d4f95053c
>
> TBR=tandrii@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= chromium:674448 
>
> Review-Url: https://codereview.chromium.org/2583443002
> Cr-Commit-Position: refs/heads/master@{#41711}
> Committed: https://chromium.googlesource.com/v8/v8/+/4619fbe42a91de67abe4f794cf67274035776d84

TBR=tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:674448 

Review-Url: https://codereview.chromium.org/2580623003
Cr-Commit-Position: refs/heads/master@{#41712}

[modify] https://crrev.com/b02fd88d75c44c0e88fd083076512c82a5f78adb/tools/whitespace.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/c568c4e6b9ad6cfab9de0b02e38468633aaf77a4

commit c568c4e6b9ad6cfab9de0b02e38468633aaf77a4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Dec 15 10:08:52 2016

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/34ea6626a3dcd13f7c333ff264b141942df2f7c4

commit 34ea6626a3dcd13f7c333ff264b141942df2f7c4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Dec 15 10:34:43 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 15 2016

Labels: merge-merged-5.3
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/58a10281ac29f5c8e1eb944547a424d634050dc6

commit 58a10281ac29f5c8e1eb944547a424d634050dc6
Author: tandrii <tandrii@chromium.org>
Date: Thu Dec 15 10:41:16 2016

CQ commit on a branch without gnumbd.

BUG= chromium:674448 
TBR=machenbach@chromium.org
NOTREECHECKS=True
NOTRY=True
NOPRESUBMIT=True

Review-Url: https://codereview.chromium.org/2577953003
Cr-Commit-Position: refs/branch-heads/5.3@{#75}
Cr-Branched-From: 820a23aade5e74a92d794e05a0c2b3597f0da4b5-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb2c1b4d75c41af386cb4fedbe5566f5608-refs/heads/master@{#37308}

[modify] https://crrev.com/58a10281ac29f5c8e1eb944547a424d634050dc6/tools/whitespace.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/50323af4fda23ad79b5ee4517d5b5c09ac665d95

commit 50323af4fda23ad79b5ee4517d5b5c09ac665d95
Author: machenbach <machenbach@chromium.org>
Date: Thu Dec 15 10:44:22 2016

Whitespace change to test gnumbd shutdown - CQ

BUG= chromium:674448 
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2578963002
Cr-Commit-Position: refs/branch-heads/5.3@{#76}
Cr-Branched-From: 820a23aade5e74a92d794e05a0c2b3597f0da4b5-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb2c1b4d75c41af386cb4fedbe5566f5608-refs/heads/master@{#37308}

[modify] https://crrev.com/50323af4fda23ad79b5ee4517d5b5c09ac665d95/tools/whitespace.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7c43fcb285dc3a009e4116831f8ab3d8433cde52

commit 7c43fcb285dc3a009e4116831f8ab3d8433cde52
Author: machenbach <machenbach@chromium.org>
Date: Thu Dec 15 11:48:54 2016

[release] Make release scripts work without gnumbd

This splits branch ref creation and landing. The ref now directly uses
heads (without pending) and for landing we use depot_tools.

For simplicity, the check for existing tags is removed, as it now
is very unlikely to happen again without gnumbd.

BUG= chromium:674448 
NOTRY=true
TBR=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2584523002
Cr-Commit-Position: refs/heads/master@{#41716}

[modify] https://crrev.com/7c43fcb285dc3a009e4116831f8ab3d8433cde52/tools/release/create_release.py
[modify] https://crrev.com/7c43fcb285dc3a009e4116831f8ab3d8433cde52/tools/release/test_scripts.py

Status: Verified (was: Started)
haha, my stuff got a label on 5.3 :)
Cc: ehmaldonado@chromium.org kjellander@chromium.org
Components: -Infra>Client>V8 Infra>Client>WebRTC
Labels: -merge-merged-5.3
Status: Started (was: Verified)
Summary: Migrate WebRTC off gnumbd (was: Migrate V8 off gnumbd)
Cc: -kjellander@chromium.org -ehmaldonado@chromium.org
Components: -Infra>Client>WebRTC Infra>Client>V8
Status: Verified (was: Started)
Summary: Migrate V8 off gnumbd (was: Migrate WebRTC off gnumbd)
Ok, turns out copying wasn't a brilliant idea.
Blocking: 644915
Labels: Milestone-Fishfood Proj-Gerrit-Migration
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/f1467cf30d9403d6ff58e09bc0c2e2b75f10f001

commit f1467cf30d9403d6ff58e09bc0c2e2b75f10f001
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Dec 19 14:24:42 2016

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/f1467cf30d9403d6ff58e09bc0c2e2b75f10f001

commit f1467cf30d9403d6ff58e09bc0c2e2b75f10f001
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Dec 19 14:24:42 2016

Sign in to add a comment