Regression: Chrome crashes on navigating to chrome://ntp-tiles-internals in incognito and guest mode |
|||||
Issue descriptionChrome Version: 57.0.2952.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1) Launch chrome and navigate to chrome://ntp-tiles-internals in incognito window or Guest mode and observe. Expected: No crash should be seen on navigating to that link. Actual: Instead browser crash is seen. This is a regression issue broken in M57. Manual Bisect Info: ==================== Good Build: 57.0.2950.0 dev Bad Build: 57.0.2951.0 dev Crash ids: 4d22da0080000000 , b28f5a0080000000
,
Dec 15 2016
Stack Trace for internal purpose: ------------------------------------- Thread 0 CRASHED [SIGSEGV @ 0x00000090 ] MAGIC SIGNATURE THREAD Stack Quality77%Show frame trust levels 0x00007fd4b4ab9920 (libstdc++.so.6.0.19 + 0x0006e920 ) 0x000055db0c54dd5f (chrome -./out/Release/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/list.tcc:103 ) suggestions::SuggestionsService::AddCallback(base::Callback<void (suggestions::SuggestionsProfile const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) 0x000055db0c503efc (chrome -./out/Release/../../components/ntp_tiles/most_visited_sites.cc:105 ) ntp_tiles::MostVisitedSites::SetMostVisitedURLsObserver(ntp_tiles::MostVisitedSites::Observer*, int) 0x000055db0e9ed8ac (chrome -./out/Release/../../components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc:52 ) ntp_tiles::NTPTilesInternalsMessageHandler::HandleRegisterForEvents(base::ListValue const*) 0x000055db0abe0714 (chrome -./out/Release/../../base/callback.h:85 ) content::WebUIImpl::ProcessWebUIMessage(GURL const&, std::string const&, base::ListValue const&) 0x000055db0abe0f92 (chrome -./out/Release/../../base/tuple.h:91 ) bool IPC::MessageT<ViewHostMsg_WebUISend_Meta, std::tuple<GURL, std::string, base::ListValue>, void>::Dispatch<content::WebUIImpl, content::WebUIImpl, void, void (content::WebUIImpl::*)(GURL const&, std::string const&, base::ListValue const&)>(IPC::Message const*, content::WebUIImpl*, content::WebUIImpl*, void*, void (content::WebUIImpl::*)(GURL const&, std::string const&, base::ListValue const&)) 0x000055db0abe0def (chrome -./out/Release/../../content/browser/webui/web_ui_impl.cc:90 ) content::WebUIImpl::OnMessageReceived(IPC::Message const&) 0x000055db0abc71f2 (chrome -./out/Release/../../content/browser/web_contents/web_contents_impl.cc:682 ) content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*, content::RenderFrameHost*, IPC::Message const&) 0x000055db0aaf7b82 (chrome -./out/Release/../../content/browser/renderer_host/render_view_host_impl.cc:757 ) content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) 0x000055db0aaff3ba (chrome -./out/Release/../../content/browser/renderer_host/render_widget_host_impl.cc:514 ) content::RenderWidgetHostImpl::OnMessageReceived(IPC::Message const&) 0x000055db0bcf0099 (chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:340 ) IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) 0x000055db0b3e456d (chrome -./out/Release/../../base/callback.h:68 ) base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) 0x000055db0b37aeef (chrome -./out/Release/../../base/message_loop/message_loop.cc:413 ) base::MessageLoop::RunTask(base::PendingTask*) 0x000055db0b37a9e4 (chrome -./out/Release/../../base/message_loop/message_loop.cc:422 ) base::MessageLoop::DoWork() 0x000055db0b37c768 (chrome -./out/Release/../../base/message_loop/message_pump_glib.cc:267 ) base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) 0x00007fd4b99a3e03 (libglib-2.0.so.0.4002.0 + 0x00048e03 ) 0x00007fd4b99b2b3f (libglib-2.0.so.0.4002.0 + 0x00057b3f ) 0x00007fd4b99a4047 (libglib-2.0.so.0.4002.0 + 0x00049047 ) 0x00007fd4b99a40eb (libglib-2.0.so.0.4002.0 + 0x000490eb ) 0x000055db0b37c9c5 (chrome -./out/Release/../../base/message_loop/message_pump_glib.cc:309 ) base::MessagePumpGlib::Run(base::MessagePump::Delegate*) 0x000055db0b39927f (chrome -./out/Release/../../base/run_loop.cc:37 ) base::RunLoop::Run() 0x000055db0b256cf5 (chrome -./out/Release/../../chrome/browser/chrome_browser_main.cc:1974 ) ChromeBrowserMainParts::MainMessageLoopRun(int*) 0x000055db0a8cdbf7 (chrome -./out/Release/../../content/browser/browser_main_loop.cc:1086 ) content::BrowserMainLoop::RunMainMessageLoopParts() 0x000055db0a8cfd9c (chrome -./out/Release/../../content/browser/browser_main_runner.cc:141 ) content::BrowserMainRunnerImpl::Run() 0x000055db0a8c7df8 (chrome -./out/Release/../../content/browser/browser_main.cc:46 ) content::BrowserMain(content::MainFunctionParams const&) 0x000055db0b000c4b (chrome -./out/Release/../../content/app/content_main_runner.cc:793 ) content::ContentMainRunnerImpl::Run() 0x000055db0afff70d (chrome -./out/Release/../../content/app/content_main.cc:20 ) content::ContentMain(content::ContentMainParams const&) 0x000055db09ca0a20 (chrome -./out/Release/../../chrome/app/chrome_main.cc:109 ) ChromeMain 0x00007fd4b4491ec4 (libc-2.19.so -libc-start.c:287 ) __libc_start_main 0x000055db09c96bc0 (chrome + 0x00b48bc0 ) _start
,
Dec 15 2016
Since this is a new implementation in chrome removing dev blocker and marking it as stable blocker. Thanks!
,
Dec 15 2016
,
Jan 2 2017
Issue 677768 has been merged into this issue.
,
Jan 11 2017
sfiera@ Is there any update on this?
,
Jan 11 2017
https://codereview.chromium.org/2584483002/ contains a fix. I was busy until FF, so it needs a rebase and then can go in.
,
Jan 17 2017
As it is marked as ReleaseBlock-Stable, could we get any update on this issue. Thanks..
,
Jan 17 2017
Aforementioned CL is in CQ now.
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b20f0039e91883b8f001390a2f21616b4ec5752d commit b20f0039e91883b8f001390a2f21616b4ec5752d Author: sfiera <sfiera@chromium.org> Date: Tue Jan 17 14:51:31 2017 Fix ntp-tiles-internals crash in incognito mode NTP Tiles aren't supported in Incognito mode, so disable the handlers in that case. BUG= 674441 Review-Url: https://codereview.chromium.org/2584483002 Cr-Commit-Position: refs/heads/master@{#444050} [modify] https://crrev.com/b20f0039e91883b8f001390a2f21616b4ec5752d/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc [modify] https://crrev.com/b20f0039e91883b8f001390a2f21616b4ec5752d/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc [modify] https://crrev.com/b20f0039e91883b8f001390a2f21616b4ec5752d/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h [modify] https://crrev.com/b20f0039e91883b8f001390a2f21616b4ec5752d/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
,
Jan 17 2017
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11764f420eec90c09ae7001aa753fef1e343c493 commit 11764f420eec90c09ae7001aa753fef1e343c493 Author: sfiera <sfiera@chromium.org> Date: Wed Jan 18 17:40:20 2017 Properly detect if Chrome is incognito I misunderstood the comment for HasOffTheRecordChromeBrowserState(). BUG= 674441 Review-Url: https://codereview.chromium.org/2645453003 Cr-Commit-Position: refs/heads/master@{#444412} [modify] https://crrev.com/11764f420eec90c09ae7001aa753fef1e343c493/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brajkumar@chromium.org
, Dec 15 2016Owner: sfiera@chromium.org
Status: Assigned (was: Unconfirmed)