Files app can fail to start when calling chrome.storage APIs fails. |
||||||
Issue descriptionFeedback report: #21496332704 In the report, Files app opens without any contents, and it keeps blank. According to the log, a chrome.storage API call failed. When a chrome.storage.get/set fails, chrome.runtime.lastError is set and we need to handle it. In some parts in Files app, they are not handled and it result in empty Files app, since the initialization process aborts due to unhandled lastError. We need to handle the error to ensure that Files app works even in such situations.
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26defffaca3b257fae0f625d04fc14724fc71682 commit 26defffaca3b257fae0f625d04fc14724fc71682 Author: fukino <fukino@chromium.org> Date: Thu Dec 15 11:42:09 2016 Files app: Handle chrome.runtime.lastError for chrome.storage API calls. BUG= 671080 , 674434 TEST=manually tested by modifying chrome.storage API to return errors and confirming that Files app works properly with default options. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578863003 Cr-Commit-Position: refs/heads/master@{#438806} [modify] https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682/ui/file_manager/file_manager/foreground/js/app_state_controller.js [modify] https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js [modify] https://crrev.com/26defffaca3b257fae0f625d04fc14724fc71682/ui/file_manager/file_manager/foreground/js/ui/banners.js
,
Dec 16 2016
I'd like to request a merge to M56, since: - The issue doesn't occur frequently, but if it happens, it is serious. users can't download/open any files. - The fix is not complex.
,
Dec 16 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8abe66c74b57ced730aa2977f93fdd59d7c4c72 commit e8abe66c74b57ced730aa2977f93fdd59d7c4c72 Author: Naoki Fukino <fukino@chromium.org> Date: Mon Dec 19 08:18:35 2016 Files app: Handle chrome.runtime.lastError for chrome.storage API calls. BUG= 671080 , 674434 TEST=manually tested by modifying chrome.storage API to return errors and confirming that Files app works properly with default options. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578863003 Cr-Commit-Position: refs/heads/master@{#438806} (cherry picked from commit 26defffaca3b257fae0f625d04fc14724fc71682) Review-Url: https://codereview.chromium.org/2589493004 . Cr-Commit-Position: refs/branch-heads/2924@{#542} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e8abe66c74b57ced730aa2977f93fdd59d7c4c72/ui/file_manager/file_manager/common/js/util.js [modify] https://crrev.com/e8abe66c74b57ced730aa2977f93fdd59d7c4c72/ui/file_manager/file_manager/foreground/js/app_state_controller.js [modify] https://crrev.com/e8abe66c74b57ced730aa2977f93fdd59d7c4c72/ui/file_manager/file_manager/foreground/js/folder_shortcuts_data_model.js [modify] https://crrev.com/e8abe66c74b57ced730aa2977f93fdd59d7c4c72/ui/file_manager/file_manager/foreground/js/ui/banners.js
,
Dec 20 2016
,
Mar 30 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fukino@chromium.org
, Dec 15 2016