New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674425 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Color of 'Filter' icon in 'Console' tab is not turn to blue after clicking on it.

Reported by rk...@etouch.net, Dec 15 2016

Issue description

Chrome Version: 57.0.2952.0 Revision 199daadb512fd39c2c8c3e56f536acb7eb941fb4-refs/heads/master@{#438707}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools and Press Esc key to open Console tab.
(2) Click on Filter icon and observe.

Actual: Color of Filter icon is not turn to blue after clicking on it.

Expected: Color of Filter icon should turn to blue after clicking on it.

This is a regression issue, broken in 'M-57', will update the other info:

Good Build: 57.0.2951.0
Bad Build: 57.0.2952.0
 
Actual_Color.mp4
402 KB View Download
Expected_color.mp4
399 KB View Download

Comment 1 by rk...@etouch.net, Dec 15 2016

Summary: Regression: Color of 'Filter' icon in 'Console' tab is not turn to blue after clicking on it. (was: Regression: Color of Filter icon in 'Console' tab is not turn to blue after clicking on it.)
Note: 1. Above issue is seen on Toggle device toolbar icon, i.e. its not turn to blue in color after clicking on it.
      2. Issue is seen on  Mac (10.11.6, 10.12.1)

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========

Good build : 57.0.2951.0,  Revision Range-438385
Bad build  : 57.0.2952.0,  Revision Range-438707

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/0be43188cb2345a40a73205bb65dd4164aa9d259..d2b33e185dd8325dd9bd7c643a466826664f076d


The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/d2b33e185dd8325dd9bd7c643a466826664f076d


From the above CL suspecting the below change
--------------------------------------------
Review-Url: https://codereview.chromium.org/2570783006

lushnikov@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Thank You...
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861

commit e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Dec 15 18:23:44 2016

DevTools: follow-up to crrev.com/2570783006

Thie crrev.com/2570783006 introduced a non-icon-mask class for
toolbarButtonGlyphs, which clashed with masked images. This patch
eliminates the clash.

BUG= 674418 ,  674425 
TBR=dgozman
NOTRY=true

Review-Url: https://codereview.chromium.org/2581753002
Cr-Commit-Position: refs/heads/master@{#438878}

[modify] https://crrev.com/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Status: Fixed (was: Assigned)
Labels: ReleaseBlock-Stable
Adding blocker label, since a recent regression.

Comment 6 by ajha@chromium.org, Jan 3 2017

Labels: TE-Verified-57.0.2970.0 TE-Verified-M57
Verified the fix on the latest canary(57.0.2970.0) on Windows-10, Mac OS 10.12.2 and Linux Ubuntu 14.04. This is working as intended. Attached is the screenshot for the same.
674425.png
341 KB View Download

Sign in to add a comment