New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674418 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Stop recording network log' iconin dev tools is not seen properly.

Reported by rk...@etouch.net, Dec 15 2016 
Chrome Version: 57.0.2952.0 Revision 199daadb512fd39c2c8c3e56f536acb7eb941fb4-refs/heads/master@{#438707}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools wondow.
(2) Navigate to Network section and observe.

Actual: Stop recording network log icon is not seen properly.

Expected: Stop recording network log icon should seen properly.

This is a regression issue, broken in 'M-57', will update the other info:

Good Build: 57.0.2951.0
Bad Build: 57.0.2952.0
Actual_Icon.mp4
272 KB View Download
Expected_Icon.mp4
194 KB View Download

Comment 1 by rbasuvula@chromium.org, Dec 15 2016

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2951.0 (Revision: 438385).
Bad build: 57.0.2952.0 (Revision: 438707).

You are probably looking for a change made after 438645 (known good), but no later than 438646 (first known bad).

CHANGE-LOG URL:
---------------------------------------
https://chromium.googlesource.com/chromium/src/+log/0be43188cb2345a40a73205bb65dd4164aa9d259..d2b33e185dd8325dd9bd7c643a466826664f076d

From the CL above, assigning the issue to the concern owner

@ lushnikov  : 
------------------
Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2570783006
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861

commit e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Dec 15 18:23:44 2016

DevTools: follow-up to crrev.com/2570783006

Thie crrev.com/2570783006 introduced a non-icon-mask class for
toolbarButtonGlyphs, which clashed with masked images. This patch
eliminates the clash.

BUG= 674418 ,  674425 
TBR=dgozman
NOTRY=true

Review-Url: https://codereview.chromium.org/2581753002
Cr-Commit-Position: refs/heads/master@{#438878}

[modify] https://crrev.com/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861

commit e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Dec 15 18:23:44 2016

DevTools: follow-up to crrev.com/2570783006

Thie crrev.com/2570783006 introduced a non-icon-mask class for
toolbarButtonGlyphs, which clashed with masked images. This patch
eliminates the clash.

BUG= 674418 ,  674425 
TBR=dgozman
NOTRY=true

Review-Url: https://codereview.chromium.org/2581753002
Cr-Commit-Position: refs/heads/master@{#438878}

[modify] https://crrev.com/e63ccacfa0b3e8bfcfa0f5c7e64239c881a20861/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Comment 4 by lushnikov@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)

Comment 5 by ranjitkan@chromium.org, Dec 16 2016

Labels: ReleaseBlock-Stable
Adding Blocker label, so this is a recent regression

Comment 6 by msrchandra@chromium.org, Jan 3 2017

Labels: TE-Verified-57.0.2970.0 TE-Verified-M57
Tested the issue on Latest Dev# 57.0.2970.0 on Windows and issue is no more reproducible.
Hence adding TE-Verified Labels.
Thank You.
►

Sign in to add a comment