Notification tray message string on lock screen overlaps with icons |
|||||
Issue descriptionChrome Version: 57.0.2937.0, 56.0.2924.26 OS: CrOS What steps will reproduce the problem? (1) lock screen (2) click notification tray What is the expected result? Message saying please unlock the device before checking out notification What happens instead? Message is displayed but some icons are overlapping the message. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Dec 16 2016
Sebastien, do you have an idea to solve this?
,
Dec 16 2016
Hiding all buttons may be a good solution. All buttons are disabled-state on lock screen.
,
Dec 16 2016
I like the idea in #3, since they are disabled. Is it also the case for muting ? Can't we mute notifications from the lock screen?
,
Dec 19 2016
Ok, let me hide them on lock screen. User can't change the mute setting on lock screen. (Note that on lock screen, notification is muted automatically regardless of the setting)
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0 commit bc9a6161faa2b8261a38df8f0d640cb42a7e26d0 Author: yoshiki <yoshiki@chromium.org> Date: Thu Feb 02 01:49:00 2017 Hide icons in message center on lock screen This patch removes all the icons in the message center when the screen is locked. This patch also sets the height of the button bar to keep the height even when all the icons are invisible in the message center. BUG= 674410 TEST=manually Review-Url: https://codereview.chromium.org/2622603003 Cr-Commit-Position: refs/heads/master@{#447679} [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_button_bar.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_button_bar.h [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view.h [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/views/layout/grid_layout.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/views/layout/grid_layout.h
,
Feb 2 2017
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0 commit bc9a6161faa2b8261a38df8f0d640cb42a7e26d0 Author: yoshiki <yoshiki@chromium.org> Date: Thu Feb 02 01:49:00 2017 Hide icons in message center on lock screen This patch removes all the icons in the message center when the screen is locked. This patch also sets the height of the button bar to keep the height even when all the icons are invisible in the message center. BUG= 674410 TEST=manually Review-Url: https://codereview.chromium.org/2622603003 Cr-Commit-Position: refs/heads/master@{#447679} [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_button_bar.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_button_bar.h [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view.h [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/message_center/views/message_center_view_unittest.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/views/layout/grid_layout.cc [modify] https://crrev.com/bc9a6161faa2b8261a38df8f0d640cb42a7e26d0/ui/views/layout/grid_layout.h
,
Mar 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by uekawa@chromium.org
, Dec 15 2016