Request: Logging for Open Bookmark when on New Tab Page |
|||||||||||
Issue descriptionI'm thinking about getting a better view on how people use the NTP on desktop platforms. We have the user action ClickedBookmarkBarURLButton. And we have the histogram Bookmarks.LaunchLocation. But neither of these helps me answer the question I have which is how many times do users click on bookmarks while on the new tab page.
,
May 8 2017
NTP folks, is there a way to answer this question nowadays?
,
May 9 2017
I'm not aware of any existing metrics that would capture this. Shouldn't be too hard to add though.
,
Sep 13 2017
,
Feb 1 2018
Who owns the (new) NTP efforts these days?
,
Feb 1 2018
,
Feb 1 2018
Note that this request is about desktop.
,
Feb 1 2018
+ramyan is ramping up on Desktop NTP ownership
,
Feb 2 2018
,
Feb 7 2018
It looks like I'll be able to do this by checking IsInstantNTP(WebContents).
,
Feb 8 2018
Ah, one more thing I thought of: IsInstantNTP will not cover the Incognito and Guest Mode NTPs. I don't know if that's good or bad in this case :)
,
Feb 8 2018
For my original use case, I would prefer if the NTP covered all possible NTPs, instant or not, incognito or not, Google default search engine or not, guest mode, etc.
,
Feb 8 2018
If it's hard to get them all (per bug 624410), then I can be satisfied with IsInstantNTP. Can we at least do IsInstantNTP() || url.spec() == chrome::kChromeUINewTabURL ? (the latter will help capture things like extension-replaced NTPs) Also, will that second term end up including incognito?
,
Feb 9 2018
IsInstantNTP already covers third-party NTPs. Adding the comparison to kChromeUINewTabURL will also capture Incognito and Guest. I don't know about extensions.
,
May 2 2018
Making this available in case someone else has cycles to work on it in the near term. WIP crrev.com/r/908049 may have some useful comments to refer to when starting on this.
,
Sep 16
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sky@chromium.org
, Dec 15 2016