New issue
Advanced search Search tips

Issue 674404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocked on:
issue 670237



Sign in to add a comment

Faster Reload: Complete migration from WebFrameLoadType::Reload to WebFrameLoadType::ReloadMainResource

Project Member Reported by toyoshim@chromium.org, Dec 15 2016

Issue description

Remove all WebFrameLoadType::Reload use cases, and change WebFrameLoadType::Reload behavior to be same with WebFrameLoadType::ReloadMainResource.
Then, remove WebFrameLoadType::ReloadMainResource.
 
Blockedon: 670237
Labels: -Type-Bug Type-Task
Owner: toyoshim@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa347f00f375a465b794912889249cbfa8b61826

commit fa347f00f375a465b794912889249cbfa8b61826
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Mar 24 03:28:50 2017

InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG= 674404 

Review-Url: https://codereview.chromium.org/2769153002
Cr-Commit-Position: refs/heads/master@{#459354}

[modify] https://crrev.com/fa347f00f375a465b794912889249cbfa8b61826/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b

commit f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Mar 24 05:37:26 2017

Should reset "Save-Data" header on all kinds of reloads

Existing code just reset the "Save-Data" HTTP header only on
FrameLoadTypeReload. But this should be done for all kinds of reload
variants including ReloadMainResource and ReloadBypassingCache.

BUG= 674404 ,  591594 

Review-Url: https://codereview.chromium.org/2769033004
Cr-Commit-Position: refs/heads/master@{#459365}

[modify] https://crrev.com/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/f67faf0fa3c57d392fcf6b5d2b1c9f324b0bc35b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac4459e32961172505fc30c395886c1236fe469

commit dac4459e32961172505fc30c395886c1236fe469
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Mar 27 06:14:50 2017

Change FrameLoadTypeReload to take FrameLoadTypeReloadMainResource's behavior

Now newly introduced FrameLoadTypeReloadMainResource is used in major
reload code paths by default. To avoid adding wrong usage of Reload, and
to clean up loading code, remove existing FrameLoadTypeReload behaviors
completely, and change the type to take FrameLoadTypeReloadMainResource's
behavior instead. This will result in removing the type
FrameLoadTypeReloadMainResource, but it means removing legacy reload
behavior actually.

BUG= 674404 
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2772753002
Cr-Commit-Position: refs/heads/master@{#459708}

[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/dac4459e32961172505fc30c395886c1236fe469/third_party/WebKit/public/web/WebFrameLoadType.h

Status: Fixed (was: Started)

Sign in to add a comment