We want to make the location setting for the origin of the default search engine the same as the location setting for omnibox searches. Design doc: https://docs.google.com/document/d/1iNVcrm5xxQf1FdCPwm2VWPoQ2F521imEomaWL7g2m5o/edit#heading=h.32rtctoevu6j
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f93a5833613dd2786cc45f9c75e2c8723f855f5 commit 0f93a5833613dd2786cc45f9c75e2c8723f855f5 Author: raymes <raymes@chromium.org> Date: Tue Dec 20 04:08:42 2016 Move kill switch and secure origin checking logic Currently the permission kill switch check and secure origin checks happen in PermissionContextBase::GetPermissionStatus. This function is virtual which means that it's easy to accidentally override this logic unintentionally, and hard to insert extra permission checks which take precedence over the user setting but not over the kill switch. This CL makes GetPermissionStatus non-virtual such that the kill switch and origin checking logic is always called and adds a new virtual GetPermissionStatusInternal function which subclasses can override as needed. TBR=tommycli@chromium.org BUG= 674389 Review-Url: https://codereview.chromium.org/2586153002 Cr-Commit-Position: refs/heads/master@{#439700} [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/media/protected_media_identifier_permission_context.cc [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/media/protected_media_identifier_permission_context.h [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/media/webrtc/media_stream_device_permission_context.cc [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/media/webrtc/media_stream_device_permission_context.h [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/notifications/notification_permission_context.cc [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/notifications/notification_permission_context.h [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/permissions/permission_context_base.cc [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/permissions/permission_context_base.h [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/plugins/flash_permission_context.cc [modify] https://crrev.com/0f93a5833613dd2786cc45f9c75e2c8723f855f5/chrome/browser/plugins/flash_permission_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35f8ada78b86be36a83236aad2f39091cf744db5 commit 35f8ada78b86be36a83236aad2f39091cf744db5 Author: benwells <benwells@chromium.org> Date: Wed Jan 04 07:16:56 2017 Move files for search geolocation into their own folder. This change also adds an OWNERS file for these files. TBR=sky, mvanouwerkerk BUG= 674389 Review-Url: https://codereview.chromium.org/2611583002 Cr-Commit-Position: refs/heads/master@{#441329} [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/BUILD.gn [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/chrome_jni_registrar.cc [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/preferences/browser_prefs_android.cc [add] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/search_geolocation/OWNERS [rename] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.cc [rename] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.h [rename] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc [rename] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/geolocation/geolocation_permission_context.cc [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/ui/android/infobars/search_geolocation_disclosure_infobar.cc [modify] https://crrev.com/35f8ada78b86be36a83236aad2f39091cf744db5/chrome/browser/ui/tab_helpers.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1622188c142fb8f4564a3a8d35e9e734bc0c80e8 commit 1622188c142fb8f4564a3a8d35e9e734bc0c80e8 Author: benwells <benwells@chromium.org> Date: Tue Mar 21 01:34:49 2017 Update finch variation study name. The same feature flag is controlled by two different studies, depending on which version of Chrome is being used. Update the study name to refer to the current version's study, now that M57 has gone to stable. BUG= 674389 Review-Url: https://codereview.chromium.org/2762583002 Cr-Commit-Position: refs/heads/master@{#458269} [modify] https://crrev.com/1622188c142fb8f4564a3a8d35e9e734bc0c80e8/testing/variations/fieldtrial_testing_config.json
Comment 1 by benwells@chromium.org
, Dec 15 2016Labels: Hotlist-LocationAttach