New issue
Advanced search Search tips

Issue 674374 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: console autocomplete with a multiline suggestion should stick to bottom

Project Member Reported by l...@chromium.org, Dec 15 2016 
Chrome Version: 55.0.2883.75

What steps will reproduce the problem?
(0) Generate some commands enough to make the console viewport scroll
(1) Evaluate a multiline statement in the console e.g:
    function foo(){
        return 5;
    }
(2) In the prompt, type the first few letters of the last command to trigger autocomplete
(3) Use the suggest box to select the last command and complete it

What is the expected result?
Console viewport should stick to bottom

What happens instead?
It does not
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1faecf64579d2d1a8525e775913fa7b6df43de6

commit c1faecf64579d2d1a8525e775913fa7b6df43de6
Author: luoe <luoe@chromium.org>
Date: Wed Apr 05 00:50:43 2017

DevTools: update console viewport scroll when prompt is resized

Console's viewport used to jump to bottom when prompt input happens. This misses
cases when prompt text changes after the 'input' event or the 'input' event
does not fire:
- Press 'Up' when not scrolled to bottom to load multiline text
- Start typing a multiline command from history and use autocomplete

Now, it will listen to a more accurate event from the text editor.

BUG= 674374 ,  698428 

Review-Url: https://codereview.chromium.org/2565113002
Cr-Commit-Position: refs/heads/master@{#461921}

[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
[modify] https://crrev.com/c1faecf64579d2d1a8525e775913fa7b6df43de6/third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js

Comment 2 by l...@chromium.org, Apr 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment