New issue
Advanced search Search tips

Issue 674353 link

Starred by 1 user
Status: Fixed
Owner:
reillyg@chromium.org
Closed: Jan 2017
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature

Blocking:
issue 492204



Sign in to add a comment

Add blocklist for USB devices

Project Member Reported by reillyg@chromium.org, Dec 15 2016 
In the event that Chrome wishes to block access to a USB device the infrastructure necessary to store and query a list of such blocked devices and update the list via a push mechanism such as Finch should be added.

This will mirror the BluetoothBlocklist: https://cs.chromium.org/chromium/src/content/browser/bluetooth/bluetooth_blocklist.h
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1d24d32857475f3b506ad69bf17db1139f1011

commit eb1d24d32857475f3b506ad69bf17db1139f1011
Author: reillyg <reillyg@chromium.org>
Date: Fri Dec 16 01:54:17 2016

Add infrastructure for a USB device blocklist.

This blocklist allows access to particular models of USB device via the
WebUSB API to be blocked via either a binary push or Finch experiment.

Manual testing of this is difficult. I added a real device to the
blocklist and verified that it was not returned by
navigator.usb.getDevices() and was not listed in the chooser.

BUG= 674353 

Review-Url: https://codereview.chromium.org/2581543002
Cr-Commit-Position: refs/heads/master@{#438981}

[modify] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/BUILD.gn
[add] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/usb/usb_blocklist.cc
[add] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/usb/usb_blocklist.h
[add] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/usb/usb_blocklist_unittest.cc
[modify] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/usb/usb_chooser_controller.cc
[modify] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/browser/usb/web_usb_permission_provider.cc
[modify] https://crrev.com/eb1d24d32857475f3b506ad69bf17db1139f1011/chrome/test/BUILD.gn

Comment 2 by reillyg@chromium.org, Jan 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment