the logic on glibc verification in commit queue is wrong. |
|||||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/compile_only_pre_cq/builds/15201/steps/BuildPackages%20%5Bdaisy_spring%5D/logs/stdio The buildbot tries to verify my glibc upgrade change. It tries to build glibc for daisy board and it treats glibc as a target package. Currently we build glibc as a host package, so the logic is wrong here.
,
Dec 15 2016
I am wondering can we relax the dependency of system-locales to upgrade glibc first, after that, we upgrade system-locales.
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9ee4db3b19814cf73a642e882b471513b4a04386 commit 9ee4db3b19814cf73a642e882b471513b4a04386 Author: Yunlian Jiang <yunlian@google.com> Date: Thu Dec 15 00:54:00 2016 Change the depenency of system-locales. The system-locales requires exactly the same version as glibc. However, we could not upgrade glibc and system-locales in the same time. This is because the glibc is built by the sdk bot, but the system-locales is built for the target. If we upgrade these two package at the same time, in the commit queue buildbot, the buildbot will try to build glibc for target and it will fail. So glibc and system-locales can fall out of sync during an upgrade. BUG= chromium:674336 TEST=cbuildbot. Change-Id: Iacfde8063914472b540661f1cd29faabc4905047 Reviewed-on: https://chromium-review.googlesource.com/419696 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/9ee4db3b19814cf73a642e882b471513b4a04386/chromeos-base/system-locales/system-locales-2.19-r1.ebuild
,
Jan 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f8dea149c230bd061d3664c78c1924a94cfa914e commit f8dea149c230bd061d3664c78c1924a94cfa914e Author: Yunlian Jiang <yunlian@google.com> Date: Fri Jan 06 18:25:38 2017 update system-locales version. glibc update finishes, we need to update system-locales accordingly. BUG= chromium:674336 TEST=emerge-falco system-locales works. Change-Id: I182e5fbb9e9d1caba7c4c3584934ab462a6e8144 Reviewed-on: https://chromium-review.googlesource.com/425918 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/f8dea149c230bd061d3664c78c1924a94cfa914e/chromeos-base/system-locales/system-locales-2.23.ebuild
,
Jan 9 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by yunlian@chromium.org
, Dec 15 2016