New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674332 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: breakpoints are not re-enabled after ctrl-Z in editor with persistence

Project Member Reported by lushnikov@chromium.org, Dec 15 2016 
My version: 57.0.2952.0

Step-by-step: 
1. Open devtools, add folder to workspace
2. Open js file, set a breakpoint
3. Edit file. Notice how breakpoint gets dimmed.
4. Undo change.

Expected: the breakpoint gets un-dimmed.
Actual: the breakpoint stays dimmed until you do new changes and "save" them.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/382f1cf54206273d88b368a6ddffe0151816e8e2

commit 382f1cf54206273d88b368a6ddffe0151816e8e2
Author: lushnikov <lushnikov@chromium.org>
Date: Thu Dec 15 05:49:52 2016

DevTools: [Persistence] sync resetting of working copy

Currently, the persistence only syncs working copy changes. However,
one of the valid change of working copy is its resetting - means that
UISourceCode becomes non-dirty again.

This patch starts resetting working copy of UISourceCode if its counterpart
got into a clean state.

BUG= 674332 
R=dgozman

Review-Url: https://codereview.chromium.org/2578823002
Cr-Commit-Position: refs/heads/master@{#438759}

[modify] https://crrev.com/382f1cf54206273d88b368a6ddffe0151816e8e2/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content-expected.txt
[modify] https://crrev.com/382f1cf54206273d88b368a6ddffe0151816e8e2/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html
[modify] https://crrev.com/382f1cf54206273d88b368a6ddffe0151816e8e2/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Comment 2 by lushnikov@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment