Make form-not-secure controllable via Finch |
||
Issue descriptionThe form-not-secure implementation can currently be switched on via a command-line flag, but not via Finch. We should make it so that the Finch field trial group switches::kMarkHttpWithPasswordsOrCcWithChipAndFormWarning turns on form-not-secure as well. To do so we'll need to update IsCreditCardAutofillHttpWarningEnabled() in autofill_experiments.cc and OnShowPasswordSuggestions() in password_autofill_manager.cc.
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04c3307c17d85118389afd8e3811daf4d60f823e commit 04c3307c17d85118389afd8e3811daf4d60f823e Author: estark <estark@chromium.org> Date: Tue Dec 20 08:47:17 2016 Make form-not-secure controllable as its own separate Finch feature Previously, form-not-secure was enabled as its own value of the --mark-non-secure-as flag. That value also enabled the "Not secure" omnibox warning. Also, the autofill code that checked for the command-line flag didn't allow us to enable it via Finch. This CL moves the form-not-secure warning into its own Finch feature and corresponding chrome://flags flag. This lets us turn it on and off via Finch, independently from the "Not secure" omnibox warning that is controlled by --mark-non-secure-as. BUG= 674320 Review-Url: https://codereview.chromium.org/2588133002 Cr-Commit-Position: refs/heads/master@{#439753} [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/chrome/app/generated_resources.grd [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/chrome/browser/about_flags.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/security_state/core/security_state.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/security_state/core/security_state.h [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/security_state/core/switches.cc [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/components/security_state/core/switches.h [modify] https://crrev.com/04c3307c17d85118389afd8e3811daf4d60f823e/tools/metrics/histograms/histograms.xml
,
Dec 20 2016
,
Jan 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56732c5de584ab7b38ba694204beaf038669cf9c commit 56732c5de584ab7b38ba694204beaf038669cf9c Author: estark <estark@chromium.org> Date: Mon Jan 16 21:36:41 2017 Enable HttpFormWarning in fieldtrial_testing_config.json BUG= 674320 Review-Url: https://codereview.chromium.org/2629663002 Cr-Commit-Position: refs/heads/master@{#443946} [modify] https://crrev.com/56732c5de584ab7b38ba694204beaf038669cf9c/testing/variations/fieldtrial_testing_config.json
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d commit b850623ef5632ca96ffcc65c13d036ca0ab3271d Author: pkalinnikov <pkalinnikov@chromium.org> Date: Tue Jan 17 13:05:15 2017 Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2629663002/ ) Reason for revert: Likely causing flakiness of PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on Mac10.11/Mac10.10/Mac10.9 Tests. Original issue's description: > Enable HttpFormWarning in fieldtrial_testing_config.json > > BUG= 674320 > > Review-Url: https://codereview.chromium.org/2629663002 > Cr-Commit-Position: refs/heads/master@{#443946} > Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c TBR=jwd@chromium.org,estark@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 674320 , 681710 Review-Url: https://codereview.chromium.org/2634093003 Cr-Commit-Position: refs/heads/master@{#444036} [modify] https://crrev.com/b850623ef5632ca96ffcc65c13d036ca0ab3271d/testing/variations/fieldtrial_testing_config.json
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c890ad04b852fcc9834b988cf896534228144bb4 commit c890ad04b852fcc9834b988cf896534228144bb4 Author: estark <estark@chromium.org> Date: Wed Jan 18 17:10:16 2017 Reland of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2634093003/ ) Reason for revert: This seemed to trigger a previously existing test issue, which I fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=681710&desc=2#c14. I'll keep an eye on the flakiness dashboard after relanding this to make sure it's fixed. Original issue's description: > Revert of Enable HttpFormWarning in fieldtrial_testing_config.json (patchset #1 id:1 of https://codereview.chromium.org/2629663002/ ) > > Reason for revert: > Likely causing flakiness of PasswordManagerBrowserTestBase.InFrameNavigationDoesNotClearPopupState on Mac10.11/Mac10.10/Mac10.9 Tests. > > Original issue's description: > > Enable HttpFormWarning in fieldtrial_testing_config.json > > > > BUG= 674320 > > > > Review-Url: https://codereview.chromium.org/2629663002 > > Cr-Commit-Position: refs/heads/master@{#443946} > > Committed: https://chromium.googlesource.com/chromium/src/+/56732c5de584ab7b38ba694204beaf038669cf9c > > TBR=jwd@chromium.org,estark@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 674320 , 681710 > > Review-Url: https://codereview.chromium.org/2634093003 > Cr-Commit-Position: refs/heads/master@{#444036} > Committed: https://chromium.googlesource.com/chromium/src/+/b850623ef5632ca96ffcc65c13d036ca0ab3271d TBR=jwd@chromium.org,pkalinnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 674320 , 681710 Review-Url: https://codereview.chromium.org/2641893002 Cr-Commit-Position: refs/heads/master@{#444404} [modify] https://crrev.com/c890ad04b852fcc9834b988cf896534228144bb4/testing/variations/fieldtrial_testing_config.json
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e41375b6455400203b432c2e15f1ae0c0090fd4 commit 6e41375b6455400203b432c2e15f1ae0c0090fd4 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu Apr 26 14:14:44 2018 Remove PasswordManagerBrowserTestWarning The feature controlled kHttpFormWarningFeature will not be launched, so the corresponding test can be removed from PWM browser tests. Bug: 674320 Change-Id: I26a53e9105719f882cf8e7b03dc47f1e62272d83 Reviewed-on: https://chromium-review.googlesource.com/1030254 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#554015} [modify] https://crrev.com/6e41375b6455400203b432c2e15f1ae0c0090fd4/chrome/browser/password_manager/password_manager_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by vabr@chromium.org
, Dec 15 2016