New issue
Advanced search Search tips

Issue 674313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 671805



Sign in to add a comment

Merge RandomOrderExpectations into TestExpectations

Project Member Reported by jeffcarp@chromium.org, Dec 14 2016

Issue description

For https://codereview.chromium.org/2557673003 to land and not immediately break all builds, we need to merge RandomOrderExpectations into TestExpectations.
 
Update: merging creates a LOT of lint errors. This is going to take longer than I thought.
CL up: https://codereview.chromium.org/2575293002

Initially I merged a couple flaky test bugs into similar bugs that predated them, but because the tests in a lot of the conflicting bugs weren't exactly 1:1 I opted to comment out the offending tests in RandomOrderExpectations and will circle back on them later.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e38a374d43495ce0232f214febecceb7353e412

commit 8e38a374d43495ce0232f214febecceb7353e412
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Dec 16 01:12:15 2016

Merge RandomOrderExpectations into TestExpectations

Mark tests with pre-existing lines above as possible duplicates. Will follow up on each of those.

BUG= 674313 

Review-Url: https://codereview.chromium.org/2575293002
Cr-Commit-Position: refs/heads/master@{#438974}

[delete] https://crrev.com/0c641b54f863dca5fdd30c5e5375af919157d891/third_party/WebKit/LayoutTests/RandomOrderExpectations
[modify] https://crrev.com/8e38a374d43495ce0232f214febecceb7353e412/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
I created  https://crbug.com/675023  to follow up on the duplicates mentioned above.

Sign in to add a comment