New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo: in service manager, consolidate the NativeRunner

Project Member Reported by jcivelli@chromium.org, Dec 14 2016

Issue description

Consolidate NativeRunner as a service process launcher class that starts the service in a new process.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18dfd6cf979730171c02ed2e7ee26232fe178df7

commit 18dfd6cf979730171c02ed2e7ee26232fe178df7
Author: jcivelli <jcivelli@chromium.org>
Date: Sat Dec 17 00:40:54 2016

Consolidating the functionality offered by NativeRunner by merging the NativeRunner,
OutOfProcessNativeRunner and ChildProcessHost classes into the new ServiceProcessLauncher
class.

Also removed the equivalent of the |service_completed_callback| parameter from
NativeRunner::Start since it was not hooked to anything anymore.

BUG= 674311 

Review-Url: https://codereview.chromium.org/2576233002
Cr-Commit-Position: refs/heads/master@{#439256}

[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/chrome/app/mash/mash_runner.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/chrome/test/base/mojo_test_connector.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/chrome/test/base/mojo_test_connector.h
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/mojo/BUILD.gn
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/BUILD.gn
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/background/BUILD.gn
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/background/background_service_manager.h
[delete] https://crrev.com/59160db9d166c53f2397ad34e898bf7d1fafcec7/services/service_manager/native_runner.h
[delete] https://crrev.com/59160db9d166c53f2397ad34e898bf7d1fafcec7/services/service_manager/native_runner_delegate.h
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/runner/BUILD.gn
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/runner/host/BUILD.gn
[delete] https://crrev.com/59160db9d166c53f2397ad34e898bf7d1fafcec7/services/service_manager/runner/host/host_unittests.cc
[delete] https://crrev.com/59160db9d166c53f2397ad34e898bf7d1fafcec7/services/service_manager/runner/host/out_of_process_native_runner.cc
[delete] https://crrev.com/59160db9d166c53f2397ad34e898bf7d1fafcec7/services/service_manager/runner/host/out_of_process_native_runner.h
[rename] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/runner/host/service_process_launcher.cc
[rename] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/runner/host/service_process_launcher.h
[rename] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/runner/host/service_process_launcher_unittest.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/service_manager.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/service_manager.h
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/standalone/context.cc
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/standalone/context.h
[modify] https://crrev.com/18dfd6cf979730171c02ed2e7ee26232fe178df7/services/service_manager/tests/BUILD.gn

Status: Fixed (was: Untriaged)

Sign in to add a comment