New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674306 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

ShapeDetector: Either reject always or resolve always detect()s when the input has zero dimensions

Project Member Reported by mcasas@chromium.org, Dec 14 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abcbc58fa094efca8d7b46d6b6537c37b0e90e63

commit abcbc58fa094efca8d7b46d6b6537c37b0e90e63
Author: mcasas <mcasas@chromium.org>
Date: Wed Jan 11 00:12:13 2017

Shape Detection: resolve with empty results if any input element's dimension is zero

This CL homogenises the behaviour of the ShapeDetector's
detect() in case of an input element with any zero dimension.
Assuming such input element pass the cross origin test and
its underlying pixel data can be retrieved, then if either width
or height is zero, detect() Promise is resolved with an empty
array.

LayoutTests are adapted/extended/cleaned up.

BUG= 674306 

Review-Url: https://codereview.chromium.org/2626743002
Cr-Commit-Position: refs/heads/master@{#442737}

[modify] https://crrev.com/abcbc58fa094efca8d7b46d6b6537c37b0e90e63/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-empty-input.html
[modify] https://crrev.com/abcbc58fa094efca8d7b46d6b6537c37b0e90e63/third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-security-test.html
[modify] https://crrev.com/abcbc58fa094efca8d7b46d6b6537c37b0e90e63/third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp

Comment 2 by mcasas@chromium.org, Jan 11 2017

Labels: -OS-Mac OS-All
Owner: mcasas@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment