btw some of these failures might be due to WebContentsObserverProxy overriding some WebContentsObserver methods that don't work with PlzNavigate.

See WebContentsObserver's header for methods that are deprecated, these need to be replaced. i.e.
DidStartNavigationToPendingEntry/DidStartProvisionalLoadForFrame -> DidStartNavigation
DidCommitProvisionalLoadForFrame/DidFailProvisionalLoad/DidNavigateMainFrame/DidNavigateAnyFrame -> DidFinishNavigation

Looking at this, none of the new methods / objects are currently piped into Java. We don't have proxy observer for DidStartNavigation/DidFinishNavigation and we'll probably need a java wrapper for the NavigationHandle object.

I imagine we would need the observers to change not just in the tests, but in the code as well? Currently there are plenty observers in code looking at methods that are marked as deprecated on the C++ interface.

Amendment: Looks like DidFinishNavigation is there (with a subset of parameters being passed to java as primitives), but I don't see the rest of the methods.

Re comment 2, yes we'll want to change the code as well. Usually, but not always because of non perfect test coverage, fixing tests is what motivates fixing the shipping code.

After the WebContentsObserverProxy changes landed, we still have a bunch of failures:

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/231186
org.chromium.chrome.browser.ntp.NewTabPageTest#testUrlFocusAnimationsEnabledOnFailedLoad
org.chromium.chrome.browser.media.ui.NotificationActionsUpdatedTest#testActionsPersistAfterInPageNavigation
org.chromium.chrome.browser.webapps.WebappModeTest#testWebappHandlesWindowOpenInTabbedMode
org.chromium.chrome.browser.externalnav.UrlOverridingTest#testNavigationFromTimer
org.chromium.chrome.browser.TabThemeTest#testThemeColorIsCorrect
org.chromium.chrome.browser.BindingManagerIntegrationTest#testRestoreSharedRenderer
org.chromium.chrome.browser.externalnav.UrlOverridingTest#testNavigationWithFallbackURL
org.chromium.chrome.browser.banners.AppBannerManagerTest#testBannerFallsBackToShortName
org.chromium.chrome.browser.externalnav.UrlOverridingTest#testNavigationFromXHRCallbackAndLongTimeout
org.chromium.chrome.browser.BindingManagerIntegrationTest#testCrashInForeground
org.chromium.chrome.browser.toolbar.BrandColorTest#testBrandColorInterstitial
org.chromium.chrome.browser.webapps.WebappModeTest#testWebappHandlesSuppressedWindowOpenInTabbedMode
org.chromium.chrome.browser.TabsOpenedFromExternalAppTest#testHttpsReferrerFromFirstPartyNoDowngrade
org.chromium.chrome.browser.media.ui.NotificationTitleUpdatedTest#testMediaMetadataPersistsAfterInPageNavigation

Maria: any chance you or someone on your team can help investigate these failures? Thanks

Ted, is there anyone on your team who could take a look at this?

Sadly no one right now.  I'm OOO for the next two days, but I can try to take a look Friday.

Adding Shakti in case he's not aware of these.

Is this fixed already?

The bug this depends on is marked as fixed.
And the bug which depends on this one is marked fixed.

I think so. We can double check on https://codereview.chromium.org/2385413004/ later.

Yep it's fixed, thanks for all the help.

Apologies, applied the wrong component in bulk.