Issue metadata
Sign in to add a comment
|
org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest_testPrefetchFailoverRequestMadeAfterOpen failing with PlzNavigate |
||||||||||||||||||||||||
Issue descriptionSee this sample test run: https://codereview.chromium.org/2574953002/#ps80001 https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/199299 To run the test with PlzNavigate, add --enable-browser-side-navigation
,
Jan 18 2017
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51787340a7c9f2c1c84a522f7dc8ac0b4025440f commit 51787340a7c9f2c1c84a522f7dc8ac0b4025440f Author: donnd <donnd@chromium.org> Date: Thu Jan 19 22:18:32 2017 [TTS] Fix a test that's failing with PlzNavigate enabled. Fix ContextualSearchManagerTest_testPrefetchFailoverRequestMadeAfterOpen failing with PlzNavigate. When we simulate a navigation failure we follow that with a call to stop navigation. This causes NavigationHandleImpl::GetPageTransition to fail an assert because the navigation has not actually started yet, due to the way we partially fake navigation in tests. This CL vectors stopping the navigation through our NetworkCommunicator, since network control actions should not run live in tests. BUG= 674303 Review-Url: https://codereview.chromium.org/2644933002 Cr-Commit-Position: refs/heads/master@{#444860} [modify] https://crrev.com/51787340a7c9f2c1c84a522f7dc8ac0b4025440f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java [modify] https://crrev.com/51787340a7c9f2c1c84a522f7dc8ac0b4025440f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java [modify] https://crrev.com/51787340a7c9f2c1c84a522f7dc8ac0b4025440f/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFakeServer.java
,
Jan 24 2017
,
Jan 24 2017
Thank you!
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by donnd@chromium.org
, Jan 18 2017