Issue metadata
Sign in to add a comment
|
Korean IME doesn't work properly on Google Document |
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2951.0 Platform : 9086.0.0 - Candy What steps will reproduce the problem? (1) go to docs.google.com and open Google Document (2) enable Korean IME,한 (3) enter "lk", (ㅣㅏ) (4) enter "j", (ㅓ) (5) enter "h", (ㅗ) What is the expected result? On step #3, "ㅣㅏ" should be entered On step #4, "ㅣㅏㅓ" should be entered On step #5, "ㅣㅏㅓㅗ" should be entered What happens instead? On step #3, there is "ㅣ" on the doc. "ㅏ" disappears On step #4, there is "ㅣㅏㅓ" on the doc. "ㅏ" shows up. On step #5, there is "ㅣㅏㅓ" on the doc. "ㅗ" disappears Please provide any additional information below. Attach a screenshot if possible. Not reproduce the issue on 9000.26.0/56.0.2924.26 - Reks
,
Dec 16 2016
Upstreamed b\33678130
,
Dec 16 2016
I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=675009#, which is the root cause of this issue (and is independent of Google Docs).
,
Jan 9 2017
,
Jan 16 2017
This seems not a dup to issue 675009, as the issue 675009 can repro in M56 while this issue cannot.
,
Jan 16 2017
M57 9003.0.0 is last known good and 9004.0.0 is bad (repros this issue). Bisecting the root cause cl: https://chromium.googlesource.com/chromium/src/+log/56.0.2923.0..57.0.2925.0?pretty=fuller&n=10000
,
Jan 17 2017
Bisected and the cl https://codereview.chromium.org/2493703002/ is the cause. Reassign to yabinh@ for appropriate fix.
,
Jan 17 2017
,
Jan 18 2017
,
Jan 18 2017
We produce selectionchange event after a message loop, so it should not be relevant. Did yabinh@'s CL also cause input(beforeinput) and compositionend event order change? If so, it is possible that Docs isn't handling them correctly.
,
Jan 18 2017
As issue addressed by that patch http://crbug.com/663944 was theoretical, how about reverting?
,
Jan 18 2017
Reply to comment 10: Checked https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html with clank. It seems that the event order is expected. Here is the event list. (Note that there is no selectionchange listener in the above html.) 1. input 'a': keydown, compositionstart, compositionupdate, input, keyup 2. then input 'b': keydown, compositionupdate, input, keyup 3. then input space: compositionupdate, textinput, input, compositionend,keyup keydown, textinput, input, keyup 4. then press backspace to delete the space: keydown, input, keyup 5. press backspace again to delete 'b': keydown, compositionupdate, input, keyup 6. press backspace again to delete the remaining 'a': keydown, input, compositionupdate, textinput, compositionend, keyup
,
Jan 18 2017
Re #10, the bisect was done based on the same Document, so it is unlikely caused by Google Docs code. Re #12, this issue doesn't repro for Chinese Pinyin IME but only repros on Korean IME because Korean IME has a special behavior: 1) pressing 'l' will generate composition text 'ㅣ' 2) pressing 'k' will finish composition 'ㅣ' and generate a new composition text 'ㅏ' Can you please verify the event order with/without your cl? Thanks!
,
Jan 18 2017
I checked the event on Android. Here is the result: When inputting 'ㅣ' on https://cdn.rawgit.com/w3c/uievents/gh-pages/tools/key-event-viewer.html: 1) For Chrome Canary 57.0.2951.0 or before, the result is: keydown, compositionstart, compositionupdate, input, keyup, keydown, keyup 2) For Chrome Canary 57.0.2952.0 or after, the result is: keydown, compositionstart, compositionupdate, input, keyup, keydown, [compositionupdate, input,] keyup The additional compositionupdate & input is caused by additional call of setComposingText("ㅣ"). I think it might be root cause to this issue. But it might be a different bug. I reverted my CL, but still got additional events. Besides, 2951 was released on Dec 14th, while my CL was landed on Nov 18th.
,
Jan 18 2017
Yabin, this issue is ChromeOS-specific, so this would need to be investigated on a ChromeOS device, not Android. shuchen@, we don't have a ChromeOS setup, so is there a way we could simulate the ChromeOS Korean IME on Linux? Or, does this affect Korean IME on any other platform? Anyway, because this seems time-consuming to investigate and M57 branch point is coming up tomorrow, I have a revert up at https://codereview.chromium.org/2644623003
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53003b5bb24d266ac78adf0623b2dd07c1ac6e9f commit 53003b5bb24d266ac78adf0623b2dd07c1ac6e9f Author: aelias <aelias@chromium.org> Date: Thu Jan 19 01:38:43 2017 Revert 'Make "compositionend" event fired after setting caret position' This reverts http://crrev.com/2493703002, which was bisected to cause Google Docs Korean IME issue 674295 . Note the revert is unclean in that the structural changes to InputMethodControllerTest are preserved (only the new tests are deleted) and a new updateStyleAndLayoutIgnorePendingStylesheets was needed because of changes since the original landing. TBR=yosin@chromium.org BUG= 674295 , 663944 Review-Url: https://codereview.chromium.org/2644623003 Cr-Commit-Position: refs/heads/master@{#444593} [modify] https://crrev.com/53003b5bb24d266ac78adf0623b2dd07c1ac6e9f/third_party/WebKit/Source/core/editing/InputMethodController.cpp [modify] https://crrev.com/53003b5bb24d266ac78adf0623b2dd07c1ac6e9f/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
,
Jan 19 2017
,
Jan 19 2017
Re #15, you can use http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromium-browser. Make sure you build your Chromium binary with flags "buildtype=Offical" & "branding=Chrome".
,
Jan 24 2017
Not reproduce the issue on CrOS 9202.1.0/Chrome 57.0.2987.6 - Paine, Reks. KO IME works properly on Google docs.
,
Jan 24 2017
,
Jan 24 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by songsuk@chromium.org
, Dec 14 2016