New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674272 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not working at Google anymore
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Delete the chrome-extension-resource:// scheme

Project Member Reported by nick@chromium.org, Dec 14 2016

Issue description

There is a protocol handler for a scheme called "chrome-extension-resource://".

It does not appear to do anything, and should be deleted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26

commit 0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26
Author: nick <nick@chromium.org>
Date: Fri Dec 16 20:52:07 2016

Remove chrome-extension-resource:// scheme.

As far as I can tell this scheme does not do anything. It serves files
from a directory that appears not to exist in a default install of
Chrome for Windows, and I do not see code (outside of tests of this
scheme) that would serve to create such a directory.

BUG= 674272 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2574763003
Cr-Commit-Position: refs/heads/master@{#439182}

[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/BUILD.gn
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/browser/extensions/extension_resource_protocols.cc
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/browser/extensions/extension_resource_protocols.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/browser/resources/BUILD.gn
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/browser/resources/extension_resource/demo/library.js
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/chrome_paths.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/chrome_paths.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/extensions/docs/examples/api/downloads/download_filename_controller/manifest.json
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/extensions/docs/templates/articles/app_codelab_import_todomvc.html
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/extensions/docs/templates/articles/contentSecurityPolicy.html
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/url_constants.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/common/url_constants.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/renderer/extensions/chrome_extensions_renderer_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/renderer/extensions/resource_request_policy.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/renderer/extensions/resource_request_policy.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/chrome/test/BUILD.gn
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/test/data/extensions/api_test/accessible_cer/background.js
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/test/data/extensions/api_test/accessible_cer/main.html
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/test/data/extensions/api_test/accessible_cer/manifest.json
[delete] https://crrev.com/8d6f584a6fe7fdc6dace38a8442e697d8c72671c/chrome/test/data/extensions/api_test/extension_resource_request_policy/web_accessible/nonaccessible_chrome_resource_scheme.html
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/BUILD.gn
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/browser/extension_web_contents_observer.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/constants.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/constants.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/csp_validator.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/csp_validator_unittest.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/file_util.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/file_util.h
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/common/file_util_unittest.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/shell/browser/shell_browser_context.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/shell/browser/shell_browser_main_parts.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/shell/common/shell_content_client.cc
[modify] https://crrev.com/0fbc39212270a8aa81a88ba25cc25fdf3a7ffd26/extensions/test/extensions_unittests_main.cc

Comment 2 by nick@chromium.org, Dec 19 2016

Fixed

Comment 3 by nick@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Sign in to add a comment