Split WindowObserver::OnWindowVisibilityChanged into different functions |
||
Issue descriptionOnWindowVisibilityChanged() is sent in two distinct cases: . when the visibility of the window the observer was added to changes. . when the visibility of an ancestor of (or descendant) changes. It's extremely easy to miss the latter and leads to subtle bugs. To make this more obvious we should introduce explicit functions for the latter case, problem: OnWindowVisibilityOfAncestorChanged(); OnWindowVisibilityOfDescendantChanged(); Or pass in a parameter to OnWindowVisibilityChanged() indicating the relation. Either one makes it more obvious when the function is called.
,
Dec 14 2016
Maybe keeping a single function but adding a parameter would be clearest?
,
Aug 21
Archiving old bugs that haven't been actively assigned in over a year. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Aug 21
Archiving old bugs that haven't been actively assigned in over a year. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by msw@chromium.org
, Dec 14 2016