New issue
Advanced search Search tips

Issue 674259 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

extension search omnibox icon misaligned on all platforms except windows

Project Member Reported by est...@chromium.org, Dec 14 2016

Issue description

see screenshot
 
2016-12-14.png
35.7 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32426e0c6511485debbf3b7c77e87791b6b3ec93

commit 32426e0c6511485debbf3b7c77e87791b6b3ec93
Author: estade <estade@chromium.org>
Date: Sun Dec 18 01:26:17 2016

Make some updates to extension iconography.

Several related changes in one go:

1. Remove padding from extension search icon in location bar
   (linux, cros, mac). This was causing misalignment between the popup
   icon and the location bar icon, and unintended discrepancies between
   platforms.
2. Make ExtensionIconManager handle all supported scale factors rather
   than just 1x.
3. Remove some obsolete code in the apps page. Apps will always be given
   a default icon, and we never use the small icon codepath any more.
   This also means FaviconWebUIHandler is no longer needed.

BUG= 674259 , 596757 
TBR=kinaba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576833002
Cr-Commit-Position: refs/heads/master@{#439361}

[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/api/management/chrome_management_api_delegate.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/api/omnibox/omnibox_api.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/api/omnibox/omnibox_api.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/context_menu_matcher.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/extension_icon_manager.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/extension_icon_manager.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/extension_icon_manager_unittest.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/extension_util.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/menu_manager.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/extensions/menu_manager.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/resources/ntp4/apps_page.css
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/resources/ntp4/apps_page.js
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/resources/ntp4/new_tab.html
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/resources/ntp4/new_tab.js
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/resources/ntp4/page_list_view.js
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/webui/app_launcher_page_ui.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/webui/extensions/extension_icon_source.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/webui/extensions/extension_icon_source.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[delete] https://crrev.com/111fdd030ce49ce1de525ac10a983bed8fd8720e/chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
[delete] https://crrev.com/111fdd030ce49ce1de525ac10a983bed8fd8720e/chrome/browser/ui/webui/ntp/favicon_webui_handler.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/browser/ui/webui/ntp/new_tab_ui.cc
[add] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/test/data/extensions/context_menus/icons/16.png
[add] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/test/data/extensions/context_menus/icons/24.png
[add] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/test/data/extensions/context_menus/icons/32.png
[add] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/test/data/extensions/context_menus/icons/manifest.json
[add] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/chrome/test/data/extensions/context_menus/icons/sample.js
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/extensions/browser/api/management/management_api.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/extensions/browser/api/management/management_api_delegate.h
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/extensions/browser/image_loader.cc
[modify] https://crrev.com/32426e0c6511485debbf3b7c77e87791b6b3ec93/extensions/browser/image_loader.h

Comment 2 by est...@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Sign in to add a comment