CQ Dry Run button is shown for Chrome OS changes. |
|||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. View change https://chromium-review.googlesource.com/c/399478/ What is the expected output? The CQ Dry Run button doesn't seem to make sense for Chrome OS and shouldn't exist. What do you see instead? It exists. Please provide any additional information below.
,
Dec 14 2016
,
Dec 14 2016
,
Dec 15 2016
Also, the "Submit to CQ Button" should not exist.
,
Jan 11 2017
,
Jan 12 2017
Let me make sure my understanding is correct, and please help me fill in the gaps: The ChromeOS CQ should have a single button: * Applies CQ+1 label * Is the primary action (button is blue) * Says "Send to pre-CQ" (something better?) when available * Says "In pre-CQ" (something better?) when already set And there should be no button which applies CQ+2. Is that correct?
,
Jan 17 2017
,
Jan 18 2017
The above CL has been landed. It will go live with the next deployment. Leaving this bug open since it is the sole blocker for making PG the default for our gerrit hosts, so keeping it open is a more accurate indication of that bug's state.
,
Feb 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by andyb...@chromium.org
, Dec 14 2016