New issue
Advanced search Search tips

Issue 674252 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 680206
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Previous locations:
gerrit:5143


Sign in to add a comment

Buildbucket plugin may show jobs for wrong patchset (caching?)

Project Member Reported by machenb...@chromium.org, Dec 14 2016

Issue description

Affected Version:
2.13.3-1801-g906c470

What steps will reproduce the problem?
1. Run a trybot, e.g. presubmit from a dry run on a broken CL
2. The trybot fails, repeat a few times.

What is the expected output?
I'd expect to either see all try attempts, or have an option to expand to all try attempts, just like in Rietveld.

What do you see instead?
The UI only shows the last X attempts, not all and there's no button to click to get all tryjobs.

Please provide any additional information below.
Sometimes, a particular try run contains important information, e.g. it failed in a particular way. I want to be able to get back to that information later, no matter how many new tries there are.
 
Strange, now a few minutes later it started showing all the try attempts when switching the patchsets. Before, there seemed to be a lag that was long enough to no show the accurate jobs.

Maybe, if there is asynchronous loading going on in the background that loads the try attempts, don't show any try attempts when a patchset is switched and only show the boxes once they are completely loaded?
Doesn't repro anymore anywhere. Never mind unless the problem might be known...
Now it repros again in:
https://chromium-review.googlesource.com/c/419475

It seems like my original description is wrong. The problem is that it shows the trybots for a wrong patchset (and in an outdated state). It just randomly hangs and at some point shows the right ones very fast again.

Now after uploading patchset 5, I continued to see an unfinished presubmit (yellowish) from patchset4. If I cycle through the patchsets I continue to see only that one yellow job. Clicking on the job leads to a page that shows the bot red since minutes.

Refreshing by clicking on the number 419475 in the top left didn't help, but clicking F5 finally helped and I saw an updating version again.
Labels: -Restrict-View-Google
Status: Accepted (was: New)
Project: chromium
Moved issue gerrit:5143 to now be  issue chromium:674252 .
Components: Infra>Codereview>Gerrit
Labels: Milestone-Dogfood Proj-Gerrit-Migration Pri-2 Type-Bug
Owner: aga...@chromium.org
Status: Assigned (was: Accepted)

Comment 7 by aga...@chromium.org, Dec 15 2016

Cc: machenb...@chromium.org
Summary: Buildbucket plugin may show jobs for wrong patchset (caching?) (was: Only very few tryjobs of the same type are shown if they failed)
I can't reproduce this, even on the CL you linked. For me, every patchset shows exactly the jobs which were triggered for that patchset.

Unfortunately, that means that this is going to be super low priority, since I can't reproduce and it seems to be flaky anyway.
I'm guessing repro, will try to confirm later:

1. Run a trybot on a patchset -> see it running in UI, i.e. yellow box
2. While it runs upload a new patchset
3. Press dryrun
4. Only refresh the page by clicking on the issue number link again on the top left - dont press F5
5. Navigate between the patchsets.
Meh, even that doesn't repro. Just tried it on https://chromium-review.googlesource.com/c/420284

If I have the patience I might try also a test with a CL that's similar to my first one, i.e. lots of failing presubmits in an older patchset...

Very low prio sounds good. As it also seems to work well most of the time.
Labels: -Pri-2 Pri-3
Status: Fixed (was: Assigned)
My understanding of js sort was wrong, I fixed this here: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/9dd66d38050dbb1f2c1cb2183061be978b967073

You may see it again until the plugin is next deployed.
Mergedinto: 680206
Status: Duplicate (was: Fixed)

Sign in to add a comment