afakhry@ is this related to the crashpad vs breakpad issue you mentioned yesterday?

Reproduce the issue on 57.0.2951.0/9086.0.0 - Candy,

Not reproduce the issue on Chrome 57.0.2950.0/9085.0.0 - Paine

Yes, I think so. I think mark@ can explain what's going on and probably triage.

Able to reproduce the issue on the latest M-57, chrome version: 57.0.2953.0 of Linux as well. Works fine on Mac OS 10.12.2 and Windows-10 with the same chrome version.

Regressed in M-57.

Last good build: 57.0.2950.0
First bad build: 57.0.2951.0

Changelog:
===========
https://chromium.googlesource.com/chromium/src/+log/7ad02f9ac069e7f594b5f385bd20286e420bfd93..d8027b2065994c2a5b8cbea2821971dc60b7c6f5

jiameng@: Could you please take a look at this.

Thank you!

Issue 674074 has been merged into this issue.

 Issue 674701  has been merged into this issue.

See -
https://chromium.googlesource.com/chromium/src/+/d8027b2065994c2a5b8cbea2821971dc60b7c6f5%5E%21/#F2
I used the same <ph name="CRASH_TIME">, that may be the issue.
Can you change the second one to <ph name="UPLOAD_TIME">?

Thank you!

Re #8: So there are two bugs IIUC: (1) we are displaying crash_time in place of upload_time and (2) crash_time is being incorrectly set to 1969?

This was filed with OS-Linux, OS-Chrome. Both of those are Breakpad platforms. Here’s what I told Ahmed about crash times last week:

> I think that the reason for this is simple: Breakpad doesn’t record capture
> time, but Crashpad does. When we started with this thing, everyone was on
> Breakpad, and it was an “upload list,” not even a “crash list.” All we had were
> uploaded crashes and their upload times. Crashpad fixes that, recording all
> crashes (even when upload is turned off) and tracking capture time independently
> from upload time. But we don’t have Crashpad everywhere yet, we’ve still got
> Breakpad-using platforms, which now each have different capabilities in what
> they can do in this department.

(https://codereview.chromium.org/2557983002/#msg7)

#9 - I am not sure it was displaying one value instead of the other, I think having the same name confused the internationalization API somehow, which made it show that time stamp.

Aha! So the issues are (1) we still use Breakpad on Linux & CrOS, which
don't set crash-time (2) we changed things to display crash-time as well as
upload-time and (3) we actually display only crash-time. :P

While we're fixing the templates to use upload-time correctly, perhaps we
can also make display of crash-time conditional on one actually being set,
then, to accommodate the Breakpad limitation?

Re #11: I believe the issue is that both of the placeholders in the IDS_CRASH_CRASH_TIME_FORMAT template are specified as $1, i.e. to substitute the first of the supplied parameters, which is crash-time.

Crap, I missed that. I will copy that insight to the review. Thank you.

Just wondering, do we have any update on the above fix?

Thank you!

Working on it with jiameng@ - https://codereview.chromium.org/2581983002/
Any help will be appreciated, sorry for the mess...

this won't directly fix CrOS.  the system crash reporter needs updating for that.  issue 675861 is tracking that work.

#17 - yes, I want to detect when the capture_time does not exist and show the old string in that case. If you can shed some light on detecting that in the review, that would expedite the fix...

I wrote a new change that should fix the issue for all of the platforms, it is in the code review URL. Sorry, everyone, for the trouble. :(

See https://bugs.chromium.org/p/chromium/issues/detail?id=664430#c13 - the offending change was reverted. This is fixed. Closing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ffc3925eacc602f07e724560a4b0830edf108c

commit c5ffc3925eacc602f07e724560a4b0830edf108c
Author: wez <wez@chromium.org>
Date: Fri Jan 06 23:18:25 2017

Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG= 664430 , 674249 

Review-Url: https://codereview.chromium.org/2612993003
Cr-Commit-Position: refs/heads/master@{#442091}

[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash/core/browser/resources/crashes.js
[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash_strings.grdp

Verified on 
Google Chrome	57.0.2970.0 (Official Build) dev (64-bit)
Revision	0
Platform	9156.0.0 (Official Build) dev-channel 

"Revision	0"? :S This looks like a bug...

 Issue 536065  is opened for "Revision	0"