New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674246 link

Starred by 2 users
Status: Fixed
Owner:
futhark@chromium.org
Closed: Dec 11
Cc:
szager@chromium.org
█ nainar@chromium.org
esprehn@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

clean up LayoutView style computation

Project Member Reported by skobes@chromium.org, Dec 14 2016 
Document::updateStyle sets the style of the LayoutView twice - once to apply the default styles from StyleResolver::styleForDocument and again in inheritHtmlAndBodyElementStyles.

This means style recalc will call styleDidChange on the LayoutView when nothing has really changed, contributing to bugs like  issue 672335 .  We are saved from spurious layout invalidations only by the !m_parent check in LayoutObject::setStyle, which is questionable.

We should investigate refactoring Document::updateStyle to only set the style once.  There might be circularity issues if the <html> element inherits styles.  We shouldn't allow that anyway (see  issue 590835 ).

Comment 1 by esprehn@chromium.org, Dec 14 2016 

We don't set the style unless things actually changed:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Document.cpp?q=inheritHtml&sq=package:chromium&l=1834

Where do you see it getting set with the exact same style?

Comment 2 by skobes@chromium.org, Dec 14 2016 

The ComputedStyle values have changed, but those changes are not "real" because they are going to change back in inheritHtmlAndBodyElementStyles.

Comment 3 by meade@chromium.org, Feb 13 2017

Cc: nainar@chromium.org bugsnash@chromium.org
Labels: Update-Monthly
Bugs/Naina, how does this interact with Squad?

Please change update- label when you've looked :)

Comment 4 by bugsnash@chromium.org, Feb 13 2017

Labels: -Update-Monthly Update-Quarterly
This is in the same area as Squad but not part of it, therefore changing to Update-Quarterly as this is not currently being worked on.

Comment 5 by nainar@chromium.org, Dec 6 2017

Labels: -Update-Quarterly
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by bugsnash@google.com, Dec 6

Cc: -bugsnash@chromium.org

Comment 8 by futhark@chromium.org, Dec 11

Owner: futhark@chromium.org
Status: Fixed (was: Untriaged)
I fixed this a while ago.
►

Sign in to add a comment