New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674242 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chromeos config unittest to confirm PFQ builders have paladin equivalents.

Project Member Reported by dgarr...@chromium.org, Dec 14 2016

Issue description

It seems that we need to have a paladin builder equivalent for every PFQ builder (not yet sure why).

So... we should have a unittest that confirms we have an active paladin for every active PFQ builder.
 
Labels: -current-issue
Status: Started (was: Untriaged)
We have such a test:
  testActivePfqsHavePaladins.

However, it was making some now broken assumptions about what it means to have a waterfall set.


Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a53bb43752f2402fdb122b0d5ae2a75789322baf

commit a53bb43752f2402fdb122b0d5ae2a75789322baf
Author: Don Garrett <dgarrett@google.com>
Date: Tue Apr 18 05:50:19 2017

chromeos_config_unittest: Verify PFQ builders are on the CQ.

We have long had a unittest to ensure that Chrome PFQ builders are
represented in the CQ, but it was broken by changes to our waterfall
settings. Rewrite the test to be more robust.

Also, add support for the Android PFQ.

BUG= chromium:674242 
TEST=run_tests

Change-Id: Id89f11f288f7bd9638d5c02d08384e29cb87bd29
Reviewed-on: https://chromium-review.googlesource.com/477596
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/a53bb43752f2402fdb122b0d5ae2a75789322baf/cbuildbot/chromeos_config_unittest.py

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment