New issue
Advanced search Search tips

Issue 674228 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No firstMeaningfulPaint trace event emitted on chrome://md-settings/

Project Member Reported by paulir...@chromium.org, Dec 14 2016

Issue description

We're using lighthouse to extract metrics from chrome://settings but no fMP trace event is emitted.

The user_timing category is in the trace. Plenty of fCP, but no fMP present. Perhaps something odd about the network detection?

A sample trace attached.
 
better trace, waiting 5s at end of recording to make sure we're network idle
settings_2016-12-14_11-22-35-0.trace.json.zip
1.3 MB Download
And another better trace.. :) Now including the 'loading' trace category. no sign of fMPCandidates events.
settings_2016-12-14_11-25-01-0.trace.json.zip
1.5 MB Download
This is similar to  Issue 659021 .
FMPDetector detected "network stable" before the first paint, and stopped observing layouts.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b891d60b92a6066fa1620794e244ef6e0ce65e2

commit 2b891d60b92a6066fa1620794e244ef6e0ce65e2
Author: ksakamoto <ksakamoto@chromium.org>
Date: Thu Dec 15 09:25:57 2016

[FirstMeaningfulPaint] Do not stop observing layouts before FirstContentfulPaint

This should mitigate a bug that FirstMeaningfulPaint is reported too
soon (or not reported) on some CPU-heavy pages, because network idle is
detected while CPU is busy running scripts.

BUG= 659021 , 674228 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2581633002
Cr-Commit-Position: refs/heads/master@{#438791}

[modify] https://crrev.com/2b891d60b92a6066fa1620794e244ef6e0ce65e2/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp
[modify] https://crrev.com/2b891d60b92a6066fa1620794e244ef6e0ce65e2/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

Status: Fixed (was: Assigned)
I believe this is now fixed.
most good. thank you!

Sign in to add a comment