Chrome OS will prompt to save an app to the shelf even when I already added it. |
|||||
Issue descriptionGoogle Chrome 54.0.2840.101 (Official Build) (64-bit) Revision 0 Platform 8743.85.0 (Official Build) stable-channel samus What steps will reproduce the problem? (1) Open https://ride.lyft.com (2) Save to shelf. (3) Close the app. (4) Open it again and use it a while. (5) Get prompted again :( What is the expected result? It's already in my shelf, it was even *launched* in windowed mode without an address bar. It shouldn't prompt me to save it. What happens instead? Confusingly prompts me to save it again.
,
Dec 14 2016
Do you happen to have chrome://flags/#bypass-app-banner-engagement-checks set?
,
Dec 14 2016
Nope, just the default flags on stable.
,
Dec 15 2016
cc the installability team for thoughts on how this happened Does it repro consistently for you? I'm interested to learn how many potential users may be affected.
,
Dec 15 2016
esprehn: did you use the menu item to add this to your shelf initially? It looks like the menu item on desktop doesn't record the bit that tells the banner not to show because it's already been added. The behaviour is correct if you've previously added a site via a banner instead of via the menu item. That's definitely an oversight.
,
Dec 15 2016
Yeah I probably added it myself ages ago. Btw what bug component should this go to? We need a home for bugs like this. :)
,
Dec 15 2016
Thanks for confirming. I'll have a fix in M57. Component is as (now) marked. :)
,
Jan 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e75fa3a99a360d6469ac93a442b3f06bddf57253 commit e75fa3a99a360d6469ac93a442b3f06bddf57253 Author: dominickn <dominickn@chromium.org> Date: Tue Jan 03 02:55:05 2017 Prevent app banners from displaying after desktop add to shelf. This CL records an app banner "added to homescreen" event when a user manually adds a bookmark app to their desktop or shelf (via the overflow menu). This ensures that if the added site is a progressive web app, it will not be permitted to show an app banner if the user has manually installed it. This behaviour mirrors that on Android, which already records the "added to homescreen" event on launch and when the user manually adds a site to their homescreen. BUG= 674227 Review-Url: https://codereview.chromium.org/2612493002 Cr-Commit-Position: refs/heads/master@{#441085} [modify] https://crrev.com/e75fa3a99a360d6469ac93a442b3f06bddf57253/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/e75fa3a99a360d6469ac93a442b3f06bddf57253/chrome/browser/extensions/bookmark_app_helper_unittest.cc [modify] https://crrev.com/e75fa3a99a360d6469ac93a442b3f06bddf57253/chrome/browser/ui/extensions/application_launch.cc
,
Jan 9 2017
Pretty sure this should be fixed now.
,
Mar 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by esprehn@chromium.org
, Dec 14 2016