New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674217 link

Starred by 1 user
Status: Verified
Owner:
█ kochi@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
hayato@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

<dialog>.showModal() works also in shadow DOM, but per HTML specification it shouldn't

Reported by opet...@mozilla.com, Dec 14 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

Steps to reproduce the problem:
1. Load the test
2. Click the button

What is the expected behavior?
Per specification https://html.spec.whatwg.org/multipage/forms.html#dom-dialog-showmodal
showModal() should throw when "If subject is not in a document".

What went wrong?
showModal() works also in shadow DOM.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: 
Flash Version:
/shadowv1dialog.html
467 bytes View Download

Comment 1 by domenic@chromium.org, Dec 14 2016 

We should probably fix the spec to say "is connected"

Comment 2 by ajha@chromium.org, Dec 14 2016

Labels: Needs-Milestone

Comment 3 by tkent@chromium.org, Dec 14 2016

Cc: hayato@chromium.org kochi@chromium.org
Components: -Blink>HTML Blink>HTML>Dialog

Comment 4 by kochi@chromium.org, Dec 15 2016

Cc: -kochi@chromium.org
Owner: kochi@chromium.org
Status: Started (was: Unconfirmed)
I'll work on a PR to the spec.

Comment 6 by ajha@chromium.org, Dec 15 2016

Labels: -Needs-Milestone M-57

Comment 7 by domenic@chromium.org, Dec 15 2016

Status: Fixed (was: Started)
Thanks for the spec PR kochi@! It's merged, so I'll close this now.

Comment 8 by kochi@chromium.org, Dec 16 2016

Status: Verified (was: Fixed)
Thanks!
►

Sign in to add a comment