New issue
Advanced search Search tips

Issue 674205 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Feb 2017
Cc:
seanmccullough@chromium.org
martiniss@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Fix test bugs in Sheriff-o-Matic

Project Member Reported by zhangtiff@chromium.org, Dec 14 2016 
Some frontend tests in Sheriff-o are currently broken. Others are likely to be flaky such as the time-based tests for getting the current sheriff. These should be fixed, especially before we try to get WCT running on the builders.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ad21ba215a7c1917cc64d92e5d673a5ff8b67a67

commit ad21ba215a7c1917cc64d92e5d673a5ff8b67a67
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Dec 14 22:35:22 2016

[som] fix som-annotation-tests

Change-Id: I23ac16a804a1a2ddf6b40d1b8996bba8536bcbf1

BUG= 674205 

Change-Id: I23ac16a804a1a2ddf6b40d1b8996bba8536bcbf1
Reviewed-on: https://chromium-review.googlesource.com/419788
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/ad21ba215a7c1917cc64d92e5d673a5ff8b67a67/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations.html
[modify] https://crrev.com/ad21ba215a7c1917cc64d92e5d673a5ff8b67a67/go/src/infra/appengine/sheriff-o-matic/test/som-annotations-test.html
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/90c0fdbed3d4a3f9a61c1a1b5fdbd236b8d3e7a9

commit 90c0fdbed3d4a3f9a61c1a1b5fdbd236b8d3e7a9
Author: Tiffany Zhang <zhangtiff@google.com>
Date: Wed Dec 14 22:55:53 2016

SoM: Fix test for computing sheriffs and change to use mocked timers.

BUG= 674205 

Change-Id: I488f979140b3edbb8a4a7f3e38496695934cd6bd
Reviewed-on: https://chromium-review.googlesource.com/420309
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/90c0fdbed3d4a3f9a61c1a1b5fdbd236b8d3e7a9/go/src/infra/appengine/sheriff-o-matic/test/som-drawer-test.html

Comment 3 by benhenry@google.com, Dec 19 2016

Status: Assigned (was: Untriaged)
There is an owner on this bug, but the status was not "Assigned" or "Started". Fixing. If you do not own this bug, please remove yourself as the owner and make the status "Available".

Comment 4 by zhangtiff@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment