New issue
Advanced search Search tips

Issue 674194 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

fast/forms/associatedFormControls-leak-nodes.html is flaky unless it has repeated asyncGC calls

Project Member Reported by thakis@chromium.org, Dec 14 2016

Issue description

https://codereview.chromium.org/1965753002 added a workaround that's still around. Here's a tracking bug for it.

After today's clang roll, two asyncGC calls in the inner call are needed too, that's likely the same cause.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/299b2474f698a03d54cb12e484c389b82c47d9ca

commit 299b2474f698a03d54cb12e484c389b82c47d9ca
Author: thakis <thakis@chromium.org>
Date: Wed Dec 14 19:38:00 2016

Make an existing workaround a bit broader.

Without this, the test seems to fail after clang roll
https://codereview.chromium.org/2577523002
Since there's already a workaround, this is likely triggering
the same existing bug that already has a workaround, and not
due to a new compiler bug.

BUG= 673463 , 674194 
TBR=tkent

Review-Url: https://codereview.chromium.org/2569763006
Cr-Commit-Position: refs/heads/master@{#438595}

[modify] https://crrev.com/299b2474f698a03d54cb12e484c389b82c47d9ca/third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes.html

Comment 2 by tkent@chromium.org, Dec 15 2016

The test was added for a leak by Document::m_associatedFormControls.
https://chromium.googlesource.com/chromium/src/+/ca06c84dc478d4af2aa0b37026da6fa1a679d02e%5E%21

However, m_associatedFormControls was removed by https://chromium.googlesource.com/chromium/src/+/c7e3c1f85c4691489409104d9ab53d30b52cd8d9 .

I think it's ok to remove the test.

Comment 3 by tkent@chromium.org, Dec 15 2016

Cc: keishi@chromium.org
Owner: tkent@chromium.org
Status: Started (was: Untriaged)

Comment 5 by tkent@chromium.org, Dec 15 2016

Status: Fixed (was: Started)

Sign in to add a comment