fast/forms/associatedFormControls-leak-nodes.html is flaky unless it has repeated asyncGC calls |
|||
Issue descriptionhttps://codereview.chromium.org/1965753002 added a workaround that's still around. Here's a tracking bug for it. After today's clang roll, two asyncGC calls in the inner call are needed too, that's likely the same cause.
,
Dec 15 2016
The test was added for a leak by Document::m_associatedFormControls. https://chromium.googlesource.com/chromium/src/+/ca06c84dc478d4af2aa0b37026da6fa1a679d02e%5E%21 However, m_associatedFormControls was removed by https://chromium.googlesource.com/chromium/src/+/c7e3c1f85c4691489409104d9ab53d30b52cd8d9 . I think it's ok to remove the test.
,
Dec 15 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ded565026e554a3df1623475c68885bf86c650ba commit ded565026e554a3df1623475c68885bf86c650ba Author: tkent <tkent@chromium.org> Date: Thu Dec 15 05:06:36 2016 Remove fast/forms/associatedFormControls-leak-nodes.html. It is a test for a Document leak by Document::m_associatedFormControls [1]. However [2] removed m_associatedFormControls, and now the test isn't helpful. [1] https://chromium.googlesource.com/chromium/src/+/ca06c84dc478d4af2aa0b37026da6fa1a679d02e [2] https://chromium.googlesource.com/chromium/src/+/c7e3c1f85c4691489409104d9ab53d30b52cd8d9 BUG= 674194 Review-Url: https://codereview.chromium.org/2572383002 Cr-Commit-Position: refs/heads/master@{#438751} [delete] https://crrev.com/79e26c0876da742bf51f0fc2d875a7c58d1b273a/third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes-expected.txt [delete] https://crrev.com/79e26c0876da742bf51f0fc2d875a7c58d1b273a/third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes.html
,
Dec 15 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 14 2016