New issue
Advanced search Search tips

Issue 674184 link

Starred by 0 users
Status: Fixed
Owner:
carlosk@chromium.org
Closed: Dec 1
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Offline: our tests should be awesome

Project Member Reported by carlosk@chromium.org, Dec 14 2016 
The offline efforts are creating a whole new set of features in Chrome. This requires new tests to be written and existing ones to be improved to better cover newly introduced code. 

This issue should serve as an umbrella issue to improvements made to tests that are somewhat related to Offline and don't have a better home to them. 

I don't have objective goals for when to consider this "fixed" but the subjective ones are (all must be true):
- The core set of Offline features must have launched.
- Their respective tests must be considered "good enough".
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98b091139bd28c644ab975ef39d1bc059bd60ce

commit b98b091139bd28c644ab975ef39d1bc059bd60ce
Author: carlosk <carlosk@chromium.org>
Date: Wed Dec 14 18:30:15 2016

Simple improvements to RecentTabHelperTest.

Makes simple improvements to RecentTabHelperTest:
- Use ASSERT calls in some cases where test code would crash later if
  the expectation was not met.
- Added missing check of model().is_loaded().
- Update and reenable the DownloadRequest test.

BUG= 674184 

Review-Url: https://codereview.chromium.org/2571633003
Cr-Commit-Position: refs/heads/master@{#438540}

[modify] https://crrev.com/b98b091139bd28c644ab975ef39d1bc059bd60ce/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Comment 2 by dim...@chromium.org, Dec 15 2016

Owner: carlosk@chromium.org
Status: Assigned (was: Available)

Comment 3 by chili@chromium.org, Jan 25 2017

Labels: Hotlist-Fixit

Comment 4 by carlosk@chromium.org, Mar 1 2017

Labels: -Hotlist-Fixit
Fixit update: not really a fixit issue. It's an umbrella issue for general Offline test improvements.

Comment 5 by harringtond@google.com, Nov 30 

Since there's no specific thing being asked for in this bug, and it's getting old, can we close it?

Comment 6 by carl...@google.com, Dec 1

Labels: OS-Android
Status: Fixed (was: Assigned)
Agreed. I hope other improvements will happen by the measure we touch other tests.
►

Sign in to add a comment