PageLoadMetrics counts OmniBox requests to Google as navigations |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) LOG() the committed URLs to console (2) Type a letter or two so that omnibox does a Google search What is the expected result? The chrome-instant page is not recorded. What happens instead? A Google search result page is navigated to and recorded by MetricsWebContentsObserver. E.g., https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8 This is likely having major impact on the page load metrics.
,
Dec 14 2016
Yeah, that's right, prerenders should be ignored here: https://cs.chromium.org/chromium/src/chrome/browser/page_load_metrics/page_load_tracker.cc?sq=package:chromium&dr=C&rcl=1481717748&l=308 There's a change in flight to change the prerender policy slightly: https://codereview.chromium.org/2423383002 If you do see any PageLoad.* histograms (other than perhaps PageLoad.Internal) logged for prerenders or omnibox results currently, that's definitely a significant bug & I'll fix it right away. RE: omnibox requests, I don't know that we currently explicitly filter those out. We should make sure they don't get included. We have some logic to ignore NTP requests that may make sense to augment to ignore omnibox requests as well.
,
Dec 14 2016
More thought here: omnibox requests that do cause a new page load, such as a SRP load, should be included. Omnibox requests that incrementally update the SRP as a user types additional text into the omnibox should not be included.
,
Dec 14 2016
Closing this as WontFix as I don't think there is any bug here. I'll note though that most of my page loads are prerenders, so the navigations we are recording are quite biased to those that I visit less frequently, and are less cached.
,
Dec 14 2016
Er, Bryan, did you want to leave this bug open for the SRP pages?
,
Dec 14 2016
After debugging this a bit more I think everything is working & we can close it out.
,
Dec 14 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by jkarlin@chromium.org
, Dec 14 2016