Enable tablet-style power button behavior for convertible devices |
|||||
Issue descriptionsession_manager should pass --ash-enable-tablet-power-button to Chrome when running on convertible devices that have power buttons on their sides instead of above the Backspace key. We set the touchview USE flag on most (all?) convertible devices, but using this as a proxy for power button behavior feels gross to me and seems likely to cause issues down the road. So, I'm planning to introduce a new side_power_button USE flag for this.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2edd30010faf05e3c2b990025e55525e7769b1d4 commit 2edd30010faf05e3c2b990025e55525e7769b1d4 Author: derat <derat@chromium.org> Date: Wed Dec 14 23:08:48 2016 chromeos: Tie tablet power button to --enable-touchview. Remove the --ash-enable-tablet-power-button switch and instead enable tablet-style power button behavior whenever the --enable-touchview switch is set. This matches the logic for enabling the old "quick lock" power button behavior that was replaced by tablet-style behavior. BUG= 674176 , 633304 Review-Url: https://codereview.chromium.org/2575183002 Cr-Commit-Position: refs/heads/master@{#438663} [modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/common/ash_switches.cc [modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/common/ash_switches.h [modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc [modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/ash/wm/power_button_controller.cc [modify] https://crrev.com/2edd30010faf05e3c2b990025e55525e7769b1d4/chrome/browser/chromeos/login/chrome_restart_request.cc
,
Dec 15 2016
,
Dec 19 2016
,
Apr 4 2017
,
Apr 5 2017
,
Apr 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by derat@chromium.org
, Dec 14 2016