New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674174 link

Starred by 1 user
Status: Verified
Owner:
varkha@chromium.org
Closed: Jan 2017
Cc:
█ bruthig@chromium.org
tbuck...@chromium.org
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 663129



Sign in to add a comment

Need a connection status indicator in VPN detailed page

Project Member Reported by varkha@chromium.org, Dec 14 2016 
For the Ash MD system menu VPN detailed view, the following changes are needed for text theming and connection state strings:

The currently-connected network should not have a bolded font. Instead, a second line of green text should show "Connected" as in the spec.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c1bf58180cee3eae3a380f1f53ddb22bbedede

commit e1c1bf58180cee3eae3a380f1f53ddb22bbedede
Author: varkha <varkha@chromium.org>
Date: Wed Dec 14 18:54:50 2016

[ash-md] Adds VPN network status indicators in system menu

BUG= 674174 
Test=Connect to a VPN network.
     Verify that connected network has "Connected" text indicator.

Review-Url: https://codereview.chromium.org/2571943002
Cr-Commit-Position: refs/heads/master@{#438560}

[modify] https://crrev.com/e1c1bf58180cee3eae3a380f1f53ddb22bbedede/ash/common/system/chromeos/network/vpn_list_view.cc

Comment 3 by varkha@chromium.org, Dec 14 2016

Cc: tbuck...@chromium.org
Labels: Merge-Request-56
This visual change should go in M-56 to be consistent with the network page.

Comment 4 by tdander...@chromium.org, Dec 14 2016

Cc: bruthig@chromium.org

Comment 5 by dimu@chromium.org, Dec 15 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ee09a0a7ddd52c7cb4647b809ad78592557ccc6

commit 7ee09a0a7ddd52c7cb4647b809ad78592557ccc6
Author: Ben Ruthig <bruthig@chromium.org>
Date: Sun Dec 18 22:37:26 2016

[ash-md] Adds VPN network status indicators in system menu

BUG= 674174 
Test=Connect to a VPN network.
     Verify that connected network has "Connected" text indicator.

Review-Url: https://codereview.chromium.org/2571943002
Cr-Commit-Position: refs/heads/master@{#438560}
(cherry picked from commit e1c1bf58180cee3eae3a380f1f53ddb22bbedede)

Review-Url: https://codereview.chromium.org/2589583002 .
Cr-Commit-Position: refs/branch-heads/2924@{#539}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/7ee09a0a7ddd52c7cb4647b809ad78592557ccc6/ash/common/system/chromeos/network/vpn_list_view.cc

Comment 7 by varkha@chromium.org, Jan 3 2017

Status: Fixed (was: Started)
Fixed in M-56. The remaining work if any to be tracked separately.

Comment 8 by abod...@chromium.org, May 9 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment