Issue metadata
Sign in to add a comment
|
Set card and address editor title when editing complete cards and addresses |
||||||||||||||||||||||
Issue descriptionWe set card and address editor title appropriately for incomplete card and address, however we enabled edit of the complete card and address in this CL (https://codereview.chromium.org/2492243002/). So we should set an appropriate title in this case ("Edit card" for card editor and "Edit address" for address editor).
,
Dec 14 2016
,
Dec 14 2016
What is the credit card editor title today?
,
Dec 14 2016
Empty for complete cards and addresses,
,
Dec 14 2016
,
Dec 14 2016
Good find! This is currently in Chrome 56 beta. Will need to merge into there. Don't see a reason for RVG, so removing that.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7bb5795f41d2465fdd2dd5855fab304e166ea1b commit a7bb5795f41d2465fdd2dd5855fab304e166ea1b Author: gogerald <gogerald@chromium.org> Date: Wed Dec 14 18:46:06 2016 Set card and address editor title when editing complete cards and addresses BUG= 674161 Review-Url: https://codereview.chromium.org/2569233006 Cr-Commit-Position: refs/heads/master@{#438552} [modify] https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/a7bb5795f41d2465fdd2dd5855fab304e166ea1b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
,
Dec 14 2016
,
Dec 14 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ab21a02a321164016d9e666219cee0f62af5da7 commit 4ab21a02a321164016d9e666219cee0f62af5da7 Author: gogerald <gogerald@google.com> Date: Wed Dec 14 19:16:47 2016 Set card and address editor title when editing complete cards and addresses BUG= 674161 Review-Url: https://codereview.chromium.org/2569233006 Cr-Commit-Position: refs/heads/master@{#438552} (cherry picked from commit a7bb5795f41d2465fdd2dd5855fab304e166ea1b) Review-Url: https://codereview.chromium.org/2576763002 . Cr-Commit-Position: refs/branch-heads/2924@{#495} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/4ab21a02a321164016d9e666219cee0f62af5da7/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/4ab21a02a321164016d9e666219cee0f62af5da7/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java
,
Dec 14 2016
,
Feb 22 2017
Issue 693463 has been merged into this issue.
,
Jun 27 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by gogerald@chromium.org
, Dec 14 2016