New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674157 link

Starred by 1 user
Status: Fixed
Owner:
█ alexclarke@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ mikec...@chromium.org
charliea@chromium.org
█ alexclarke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

v8.top_25_smooth failing on android bots

Project Member Reported by rnep...@chromium.org, Dec 14 2016 
Traceback (most recent call last):
  RunBenchmark at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:343
    benchmark.ShouldTearDownStateAfterEachStorySetRun())
  Run at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:229
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:87
    state.RunStory(results)
  traced_function at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  RunStory at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:301
    self._current_page, self._current_tab, results)
  traced_function at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  ValidateAndMeasurePage at /b/rr/tmpwv7Wu3/w/src/tools/perf/measurements/v8_gc_times.py:40
    self._AddV8MetricsToResults(renderer_process, results)
  traced_function at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  _AddV8MetricsToResults at /b/rr/tmpwv7Wu3/w/src/tools/perf/measurements/v8_gc_times.py:55
    self._AddCpuTimeStatsToResults(thread, results)
  traced_function at /b/rr/tmpwv7Wu3/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  _AddCpuTimeStatsToResults at /b/rr/tmpwv7Wu3/w/src/tools/perf/measurements/v8_gc_times.py:195
    cpu_time = sum(s.thread_duration for s in thread.toplevel_slices)
TypeError: unsupported operand type(s) for +: 'float' and 'NoneType'



https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf__1_%2F4015%2F%2B%2Frecipes%2Fsteps%2Fv8.top_25_smooth%2F0%2Fstdout

Comment 2 by rnep...@chromium.org, Dec 14 2016

Cc: mikec...@chromium.org charliea@chromium.org
Adding you two incase you see similar issues on the other non (1) android bots during the fixit.
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 14 2016

Cc: alexclarke@chromium.org
Owner: alexclarke@chromium.org

=== TEST FAILURE ===


=== Auto-CCing suspected CL author alexclarke@chromium.org ===

Hi alexclarke@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Scheduler refactoring to virtually elimate redundant DoWorks
Author  : alexclarke
Commit description:
  
Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

BUG= 578176 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2546423002
Cr-Commit-Position: refs/heads/master@{#438173}
Commit  : 3a6ffff92addfa71d401e2718ab99677520f250c
Date    : Tue Dec 13 15:31:18 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@438154  0          N/A      2  good
chromium@438170  0          N/A      2  good
chromium@438172  0          N/A      2  good
chromium@438173  1          N/A      2  bad    <--
chromium@438174  1          N/A      2  bad
chromium@438178  1          N/A      2  bad
chromium@438186  1          N/A      2  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 674157

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth
Test Metric: cpu_time/cpu_time
Relative Change: 0.00%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/988
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993285959931868128


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6379940361011200

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 5 by rnep...@chromium.org, Dec 14 2016 

Does this seem like something that could reasonably cause this problem? I started another bisect to confirm that it comes back the same.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 14 2016 


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Scheduler refactoring to virtually elimate redundant DoWorks
Author  : alexclarke
Commit description:
  
Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

BUG= 578176 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2546423002
Cr-Commit-Position: refs/heads/master@{#438173}
Commit  : 3a6ffff92addfa71d401e2718ab99677520f250c
Date    : Tue Dec 13 15:31:18 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@438153  0          N/A      3  good
chromium@438163  0          N/A      3  good
chromium@438168  0          N/A      3  good
chromium@438171  0          N/A      3  good
chromium@438172  0          N/A      3  good
chromium@438173  1          N/A      3  bad    <--
chromium@438193  1          N/A      3  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 674157

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests v8.top_25_smooth
Test Metric: cpu_time/cpu_time
Relative Change: 0.00%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/989
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993279762344382592


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5325884519612416

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 7 by rnep...@chromium.org, Dec 14 2016 

Just noticed the author is in London. Doing a revert, will reland it if it doesn't green up the bots.

Comment 8 by rnep...@chromium.org, Dec 14 2016 

Already was reverted.

Comment 9 by alexclarke@chromium.org, Dec 15 2016 

I've fixed the issue TSAN found, hopefully that's the same issue that was breaking this.  Will check before re-landing.

Comment 10 by alexclarke@chromium.org, Dec 15 2016 

Looks like this was because the tracing_category_ was accidentally in quotes:

TRACE_EVENT1("tracing_category_", "TaskQueueManager::DoWork", "delayed",
               delayed);

I had no idea telemetry actually looked at that!
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0

commit 8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0
Author: alexclarke <alexclarke@chromium.org>
Date: Thu Dec 15 17:20:52 2016

Scheduler refactoring to virtually eliminate redundant DoWorks

Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

Includes fix for telemetry and tsan issues.

BUG= 578176 , 674238,  674157 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
Review-Url: https://codereview.chromium.org/2546423002
Cr-Original-Commit-Position: refs/heads/master@{#438173}
Cr-Commit-Position: refs/heads/master@{#438857}

[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/cc/test/ordered_simple_task_runner.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/cc/test/ordered_simple_task_runner.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/moveable_auto_lock.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h

Comment 12 by alexclarke@chromium.org, Dec 16 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97d232ea886d11bd5f7f5b3157637e1ae92ae980

commit 97d232ea886d11bd5f7f5b3157637e1ae92ae980
Author: gab <gab@chromium.org>
Date: Tue Dec 20 01:49:42 2016

Revert of [Reland] Scheduler refactoring to virtually eliminate redundant DoWorks (patchset #11 id:200001 of https://codereview.chromium.org/2546423002/ )

Reason for revert:
http://crbug.com/674895 (revert of dependent CL must land before this one: https://codereview.chromium.org/2583333002/)

Original issue's description:
> Scheduler refactoring to virtually eliminate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect.  Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> Includes fix for telemetry and tsan issues.
>
> BUG= 578176 , 674238,  674157 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Committed: https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0
> Cr-Original-Commit-Position: refs/heads/master@{#438173}
> Cr-Commit-Position: refs/heads/master@{#438857}

TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 578176 , 674238,  674157 , 674895

Review-Url: https://codereview.chromium.org/2590593002
Cr-Commit-Position: refs/heads/master@{#439663}

[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/cc/test/ordered_simple_task_runner.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/cc/test/ordered_simple_task_runner.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/7bbecdb7f45d60b81e2d2578944daaafed174d93/third_party/WebKit/Source/platform/scheduler/base/moveable_auto_lock.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue_sets_unittest.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/97d232ea886d11bd5f7f5b3157637e1ae92ae980/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda1d2e08c6769ebdbae66db618a2fae609f170c

commit eda1d2e08c6769ebdbae66db618a2fae609f170c
Author: alexclarke <alexclarke@chromium.org>
Date: Thu Jan 26 18:23:44 2017

Scheduler refactoring to virtually eliminate redundant DoWorks

Note this patch, while useful in it's own right, needs base messageloop
cancellation support for full effect.  Until that patch lands there may be
some pointless wakeups for canceled DoWorks. This is of particular concern
for using the scheduler on the compositor thread.

Includes fix for telemetry and tsan issues.  Also fixes a lock order
inversion present in the second attempt.

BUG= 578176 , 674238,  674157 , 677404,  677041 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
Committed: https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0
Cr-Original-Original-Commit-Position: refs/heads/master@{#438173}
Cr-Original-Commit-Position: refs/heads/master@{#438857}
Review-Url: https://codereview.chromium.org/2546423002
Cr-Commit-Position: refs/heads/master@{#446380}

[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/cc/test/ordered_simple_task_runner.cc
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/cc/test/ordered_simple_task_runner.h
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/moveable_auto_lock.h
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/eda1d2e08c6769ebdbae66db618a2fae609f170c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
►

Sign in to add a comment