New issue
Advanced search Search tips

Issue 674138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename prefs::mojom::PreferencesObserver to PreferencesClient

Project Member Reported by jonr...@chromium.org, Dec 14 2016

Issue description

Since we will be creating a 1:1 pairing between prefs::mojom::PreferencesManager and prefs::mojom::PreferencesObserver it is more appropriate to name it PreferencesClient.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fce105a2049f924de6c4d7dc416ba8775125bb8

commit 0fce105a2049f924de6c4d7dc416ba8775125bb8
Author: jonross <jonross@chromium.org>
Date: Sat Feb 11 00:05:06 2017

Unify Preferences Mojom Naming to PreferencesService

Renaming:
PreferencesManager  - PreferencesService
PreferencesFactory  - PreferencesServiceFactory
PreferencesObserver - PreferencesServiceClient

Updated associated usage of manager/observer in code to service/client.
Updated PrefObserverStore to PrefClientStore.

TEST=manual, preferences_unittests, unit_tests
BUG= 674138 

Review-Url: https://codereview.chromium.org/2644893003
Cr-Commit-Position: refs/heads/master@{#449796}

[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/ash/common/wm_shell.cc
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/ash/common/wm_shell.h
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/BUILD.gn
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/prefs/preferences_connection_manager.cc
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/prefs/preferences_connection_manager.h
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/prefs/preferences_service.cc
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/prefs/preferences_service.h
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/browser/prefs/preferences_service_unittest.cc
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/chrome/test/BUILD.gn
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/cpp/BUILD.gn
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/cpp/pref_client_store.cc
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/cpp/pref_client_store.h
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/cpp/tests/BUILD.gn
[rename] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/cpp/tests/pref_client_store_unittest.cc
[modify] https://crrev.com/0fce105a2049f924de6c4d7dc416ba8775125bb8/services/preferences/public/interfaces/preferences.mojom

Status: Fixed (was: Started)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment