'F11' shortcut near 'Exit full screen' is not seen in context menu for PDF pages.
Reported by
rk...@etouch.net,
Dec 14 2016
|
|||||
Issue descriptionChrome Version: 56.0.2924.28 Revision 5079bb60c246eb7de76df56f3335ef542f87c4c3-refs/branch-heads/2924@{#481}(32/64 bit) OS: Windows(7,8,10) What steps will reproduce the problem? (1) Launch chrome, navigate to http://www.orimi.com/pdf-test.pdf (2) Press 'F11' to fullscreen the browser, right click on PDF page and observe new 'Exit full screen' option. Actual: F11 shortcut near 'Exit full screen' is not seen in context menu for exiting full screen. Expected: F11 shortcut near 'Exit full screen' should seen in context menu for exiting full screen. This is a non regression issue, seen from 'M-54'
,
Dec 14 2016
raymes@ do you know who would be best to look at this? The 'Exit Fullscreen' is in the menu, it just doesn't say 'F11' beside it.
,
Dec 14 2016
I'm not sure of anyone specific. It does seem lower priority though I think?
,
Feb 24 2017
Hi, I had some time so i looked into this issue, I have pushed the fix https://codereview.chromium.org/2718623004/ please take a look. Thanks.
,
Feb 25 2017
FTR, I added the "Exit Fullscreen" menu item for PDFs in r420961.
,
Feb 27 2017
yeah, I have added F11 shortcut for the same "Exit Fullscreen" menu item.
,
Feb 28 2017
Thanks for looking, but the code in comment 4 is not correct, and so I wondered what is the right way to do it and ended up with https://codereview.chromium.org/2720963002/
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6abab1a4e989e0675e2528750c381df3f6fb6287 commit 6abab1a4e989e0675e2528750c381df3f6fb6287 Author: thestig <thestig@chromium.org> Date: Tue Feb 28 23:50:47 2017 Make RenderViewContextMenuViews::GetBrowserAcceleratorProvider() work for GuestViews. Thereby making F11 work for the PDF Viewer in the context menu. BUG= 674108 Review-Url: https://codereview.chromium.org/2720963002 Cr-Commit-Position: refs/heads/master@{#453750} [modify] https://crrev.com/6abab1a4e989e0675e2528750c381df3f6fb6287/chrome/browser/renderer_context_menu/render_view_context_menu.h [modify] https://crrev.com/6abab1a4e989e0675e2528750c381df3f6fb6287/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc
,
Mar 1 2017
This will be fixed in M58. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Dec 14 2016