New issue
Advanced search Search tips

Issue 674104 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Google search on highlighted text is not offered amymore

Reported by nie.mam....@gmail.com, Dec 14 2016

Issue description

Steps to reproduce the problem:
1. Long-press a word on a website to highlight it
2. Navigate through context menu

What is the expected behavior?
Google search option for the highlighted text should be there, along with, e.g. "select all".

What went wrong?
It's missing.

Did this work before? Yes It works in the stable release (55.0.2883.91), it worked before the 12.12 update

Chrome version: 56.0.2924.23  Channel: beta
OS Version: 6.0.1
Flash Version: 

I've seen some issues on tests regarding context menus in the last hours, are these perhaps related?
 
Labels: Needs-Feedback
Hi,

Thanks for your report! Are you not seeing "Web search" option when text is highlighted? I tried on Nexus 6/ 6.0.1 on 55.0.2883.91 and 56.0.2924.23 and I see "Websearch", I had to tap on three dots to see "Web search" if my device screen size is small however changing orientation to landscape will display "Web search" without having to tap on three dots. If you are still seeing the issue, Please provide us device model and screenshot or video for further triaging.
"Are you not seeing "Web search" option when text is highlighted?"

Yes, I am not seeing the "Web search" option when text is highlighted.
That's literally what this issue report says.

"I tried on Nexus 6/ 6.0.1 on 55.0.2883.91"

Yes, as I said in the report, in the regression info, it DOES work in stable (55.0.2883.91).
It DOES NOT work in beta (56.0.2924.23).

Attached are screenshots from both versions.
"Web search" is the "Wyszkuaj w Google" entry (as it's a Polish version).
It's there in the stable version, between "Select all" ("Zaznacz wszystko") and "Encrypt" ("Szyfruj", since I've got a PGP app). It's missing in the beta version.
55.0.2883.91.png
219 KB View Download
56.0.2924.23.png
181 KB View Download
I changed my device language to Polski and I am not seeing the issue on Beta (see the aatchment) I installed PGP as well . Can you provide your device model and bug report ( If possible) for further triaging?


How to take a bug report on Android devices:

'Settings' -> 'Developer options' -> 'Take bug report'

Note:
You must have developer settings enabled.

Enable developer settings:

Go to the settings menu, and scroll down to "About tablet” or “About phone.” Tap it.
Scroll down to the very bottom, where you see "Build number." 
Tap the build number seven (7) times. After the third tap, you'll see a dialog that says you're four taps away from being a developer. On the seventh tap, you’ll see a dialog that says developer setting are enabled.

Screenshot_20161214-184831.png
246 KB View Download
"Can you provide your device model"

Xperia Z3 (D6603) with Android 6.0.1

"bug report ( If possible)"

It's inactive (greyed out).

Thanks for more details! I tried on the same device Xperia Z3 and couldn't repro the issue.

Please Enable 'Settings' -> 'Developer options' -> USB debugging and then try 'Settings' -> 'Developer options' -> 'Take bug report'
bugreport-2016-12-14-21-24-16.png
148 KB View Download
bugreport-2016-12-14-21-24-16.zip
2.1 MB Download
Labels: -Needs-Feedback
Owner: tedc...@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: tedc...@chromium.org jinsuk...@chromium.org
Owner: amaralp@chromium.org
While I landed a change to disable web search if you haven't gone through first run, that only happened on trunk and since you're in the full product that definitely shouldn't be the case.

Assigning to folk that changed action modes.  In particular, this change:
https://codereview.chromium.org/2407303005

I couldn't repro this either, so it is definitely surprising.  If you install Chrome Dev (https://play.google.com/store/apps/details?id=com.chrome.dev), do you see the same issue?
"If you install Chrome Dev, do you see the same issue?"

Yes, "Web search" still missing on 57.0.2950.3.
Labels: Needs-Feedback
Can you give me the list of menu items on the context menu (floating action bar)? You should see "copy/share/select-all/web search/assist", and it is not altered on Chrome by default. The behavior hasn't changed after https://codereview.chromium.org/2407303005. 

It makes me suspect it has to do with a third-party app when it adds a new menu item in the action bar. 

What is the the PGP app you installed? I'd like to test with it too. If possible, could you try uninstalling it and see if that makes any difference?


Owner: jinsuk...@chromium.org
"I've seen some issues on tests regarding context menus in the last hours, are these perhaps related?"

Let me know what they are so I can check.
It's: "copy", "share", "select all" and used to be "encrypt".

After uninstalling OpenKeychain (https://play.google.com/store/apps/details?id=org.sufficientlysecure.keychain), the "encrypt" option is gone, but "web search" didn't appear back.

Thanks for checking. The menu "assist" is optional, so only "web search" is somehow missing.

Just installed the app but still unable to reproduce the issue. 

With the app left uninstalled, would you be able to clean up all the data so Chrome can go back to clean slate and see what happens? Settings -> Apps -> Chrome Beta -> Storage -> Manage Space -> Clear All Data?  I hope it's okay to do that for the beta, assuming it's not your main web browser.


"Settings -> Apps -> Chrome Beta -> Storage -> Manage Space -> Clear All Data"

Nope, didn't help. After a clean run, logging back and syncing into the account, the "web search" option is still missing.

I did, however, manage to narrow down the issue.

Since forever, I've had the "Google" app (com.google.android.googlequicksearchbox) disabled, due to (among many other reasons) the intrusive and non-optional way it captured long press on a headset button.
Once I've re-enabled it, the search option in Chrome's context menu came back (and after disabling it again, it's once again gone, consistently).

Is there any reason why the menu option works in v55 with the Google app disabled, while doesn't in v56?
Labels: -Needs-Feedback M-56
Status: Started (was: Assigned)
Basically the item 'web search' is shown on the condition that there is an activity capable of handling the intent ACTION_WEB_SEARCH, which is Google app. But Chrome should show the menu item regardless of it since it can just show the result in a new tab. This is a regression happening in M56. Will fix it soon.

Thanks for reporting/helping figure out the cause. 
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f

commit 1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f
Author: jinsukkim <jinsukkim@chromium.org>
Date: Fri Dec 16 03:30:43 2016

Always show 'WEB SEARCH' item in action mode on Chrome

There was a regression not showing web search menu item in
select action mode on Chrome if an activity for ACTION_WEB_SEARCH
cannot be found in the system. Chrome should always show it
since it can show the search result on a new tab. This CL fixes it
by showing the item by default, and having other embedder (webview)
configure it.

BUG= 674104 

Review-Url: https://codereview.chromium.org/2577963002
Cr-Commit-Position: refs/heads/master@{#439000}

[modify] https://crrev.com/1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f/android_webview/java/src/org/chromium/android_webview/AwActionModeCallback.java
[modify] https://crrev.com/1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Status: Fixed (was: Started)
Labels: Merge-Request-56

Comment 19 by dimu@chromium.org, Dec 16 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 16 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ea04b3817cb7c4bc70b689d3d5ec8b566285b0

commit 71ea04b3817cb7c4bc70b689d3d5ec8b566285b0
Author: jinsukkim <jinsukkim@chromium.org>
Date: Fri Dec 16 22:56:42 2016

Always show 'WEB SEARCH' item in action mode on Chrome

There was a regression not showing web search menu item in
select action mode on Chrome if an activity for ACTION_WEB_SEARCH
cannot be found in the system. Chrome should always show it
since it can show the search result on a new tab. This CL fixes it
by showing the item by default, and having other embedder (webview)
configure it.

BUG= 674104 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2577963002
Cr-Commit-Position: refs/heads/master@{#439000}
(cherry picked from commit 1f1083f8bf08eeda6a0e9a48dc9e16a8dca15b9f)

Review-Url: https://codereview.chromium.org/2585643002
Cr-Commit-Position: refs/branch-heads/2924@{#533}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/71ea04b3817cb7c4bc70b689d3d5ec8b566285b0/android_webview/java/src/org/chromium/android_webview/AwActionModeCallback.java
[modify] https://crrev.com/71ea04b3817cb7c4bc70b689d3d5ec8b566285b0/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/71ea04b3817cb7c4bc70b689d3d5ec8b566285b0/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Sign in to add a comment