New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674062 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 655899



Sign in to add a comment

Regression : In flash plugin bubble, site URL is missing.

Reported by yfulgaon...@etouch.net, Dec 14 2016

Issue description

Chrome Version : 57.0.2951.0 (Official Build) eaf56dab37408dfad3152c5e00092ab99f775273-refs/heads/master@{#438385} 64 bit
OS : Mac(10.11.6, 10.12.1, 10.12)

Test URL : www.vudu.com

What steps will reproduce the problem?
1. Launch chrome, navigate to above URL, click on ‘View site info’ and block the ‘Flash’ plugin.
2. Reload the page and play any video from ’Trending Movies’ section (blocked plugin icon appears in omnibox).
3. Click on that plugin icon in omnibox and observe the site URL in bubble. 

Actual : In flash plugin bubble, site URL is missing and only “$1” text is seen.
Expected : In flash plugin bubble, site URL should be seen properly.

This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info.
Good build : 57.0.2946.0
Bad build : 57.0.2947.0

Note : This is Mac specific issue and the same is working fine on Windows & Linux OS.
 
plugin_bubble.png
83.3 KB View Download
Actual_plugins.mov
8.0 MB Download
Expected_plugin.mov
8.4 MB Download
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2946.0 (Revision: 437422).
Bad build: 57.0.2947.0 (Revision: 437705).

You are probably looking for a change made after 437652 (known good), but no later than 437653 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2ad505df6c7974c38b2130c71169e60b679bbae2..cee4c12b4204f5ab1211903d0b5fd0da8b8b5c90

@tommycli -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression. Please remove if that is not the case.

Thank You.
Labels: -M-57 M-56
This is a must-fix for M56.

I'm guessing the Mac Cocoa version has special code that makes it interact with the ContentSettingBubbleModel changes in a bad way.
Cc: lafo...@chromium.org ericde@chromium.org
Blocking: 655899
Cc: tkonch...@chromium.org
Able to reproduce the issue on mac 10.12.2 chrome canary # 57.0.2953.0
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb

commit 9a463996fbbbde1dbee191d29b28cfa16a4eb0fb
Author: tommycli <tommycli@chromium.org>
Date: Wed Dec 21 17:33:16 2016

[HBD] Update Cocoa to match removed controls from Plugins Blocked popup.

This CL leaves the xib files alone, but manually removes the unneeded
controls in the .mm file to match the Views version.

The Views code was changed in this CL:
https://codereview.chromium.org/2552343005

BUG= 674062 

Review-Url: https://codereview.chromium.org/2593743002
Cr-Commit-Position: refs/heads/master@{#440139}

[modify] https://crrev.com/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Labels: Merge-Request-56

Comment 8 by dimu@chromium.org, Dec 22 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Labels: Needs-TestConfirmation
Status: Fixed (was: Assigned)
yfulgaonkar or msrchandra:

Can you verify that this has been fixed on Mac Canary? The fix should be in versions 57.0.2959.0 and later.

Tommy
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 26 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 29 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix, working as intended in latest canary- 57.0.2970.1.

FYI: Beta RC cut is scheduled at 3.00 PM today 01/03, please merged the CL ASAP.
Correction : Verified in chrome version-57.0.2970.0
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 10 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8

commit a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8
Author: Tommy C. Li <tommycli@chromium.org>
Date: Tue Jan 10 02:01:17 2017

[HBD] Update Cocoa to match removed controls from Plugins Blocked popup.

This CL leaves the xib files alone, but manually removes the unneeded
controls in the .mm file to match the Views version.

The Views code was changed in this CL:
https://codereview.chromium.org/2552343005

BUG= 674062 

Review-Url: https://codereview.chromium.org/2593743002
Cr-Commit-Position: refs/heads/master@{#440139}
(cherry picked from commit 9a463996fbbbde1dbee191d29b28cfa16a4eb0fb)

Review-Url: https://codereview.chromium.org/2623563003 .
Cr-Commit-Position: refs/branch-heads/2924@{#710}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Labels: Needs-Feedback
verified this issue on Mac 10.12.2 with chrome version #56.0.2924.59 

These are the steps i followed 
1. Navigated to www.vudu.com
2. Clicked on the view site info and block the flash plugin and reloaded the web page.
3. clicked on the watch trailer for any movie 
4. Got the notification in the omnibox with flash plugin.

Observed that it didn't display any radio buttons with options allow or continue the blocking plugins and the button which says "Run all plugins this time"

Attaching the screenshot and screencast for reference, Could you please look into it and let us know this is the expected behavior for this fix?
Issue 674062.png
20.9 KB View Download
Issue 674062.mp4
1.6 MB View Download
Cc: -ericde@chromium.org kkaluri@chromium.org
Cc: ericde@chromium.org

Sign in to add a comment