Issue metadata
Sign in to add a comment
|
Regression : In flash plugin bubble, site URL is missing.
Reported by
yfulgaon...@etouch.net,
Dec 14 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 57.0.2951.0 (Official Build) eaf56dab37408dfad3152c5e00092ab99f775273-refs/heads/master@{#438385} 64 bit OS : Mac(10.11.6, 10.12.1, 10.12) Test URL : www.vudu.com What steps will reproduce the problem? 1. Launch chrome, navigate to above URL, click on ‘View site info’ and block the ‘Flash’ plugin. 2. Reload the page and play any video from ’Trending Movies’ section (blocked plugin icon appears in omnibox). 3. Click on that plugin icon in omnibox and observe the site URL in bubble. Actual : In flash plugin bubble, site URL is missing and only “$1” text is seen. Expected : In flash plugin bubble, site URL should be seen properly. This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info. Good build : 57.0.2946.0 Bad build : 57.0.2947.0 Note : This is Mac specific issue and the same is working fine on Windows & Linux OS.
,
Dec 15 2016
This is a must-fix for M56. I'm guessing the Mac Cocoa version has special code that makes it interact with the ContentSettingBubbleModel changes in a bad way.
,
Dec 15 2016
,
Dec 15 2016
,
Dec 16 2016
Able to reproduce the issue on mac 10.12.2 chrome canary # 57.0.2953.0
,
Dec 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb commit 9a463996fbbbde1dbee191d29b28cfa16a4eb0fb Author: tommycli <tommycli@chromium.org> Date: Wed Dec 21 17:33:16 2016 [HBD] Update Cocoa to match removed controls from Plugins Blocked popup. This CL leaves the xib files alone, but manually removes the unneeded controls in the .mm file to match the Views version. The Views code was changed in this CL: https://codereview.chromium.org/2552343005 BUG= 674062 Review-Url: https://codereview.chromium.org/2593743002 Cr-Commit-Position: refs/heads/master@{#440139} [modify] https://crrev.com/9a463996fbbbde1dbee191d29b28cfa16a4eb0fb/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
,
Dec 21 2016
,
Dec 22 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 22 2016
yfulgaonkar or msrchandra: Can you verify that this has been fixed on Mac Canary? The fix should be in versions 57.0.2959.0 and later. Tommy
,
Dec 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 29 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 3 2017
Thanks for the fix, working as intended in latest canary- 57.0.2970.1. FYI: Beta RC cut is scheduled at 3.00 PM today 01/03, please merged the CL ASAP.
,
Jan 3 2017
Correction : Verified in chrome version-57.0.2970.0
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8 commit a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Jan 10 02:01:17 2017 [HBD] Update Cocoa to match removed controls from Plugins Blocked popup. This CL leaves the xib files alone, but manually removes the unneeded controls in the .mm file to match the Views version. The Views code was changed in this CL: https://codereview.chromium.org/2552343005 BUG= 674062 Review-Url: https://codereview.chromium.org/2593743002 Cr-Commit-Position: refs/heads/master@{#440139} (cherry picked from commit 9a463996fbbbde1dbee191d29b28cfa16a4eb0fb) Review-Url: https://codereview.chromium.org/2623563003 . Cr-Commit-Position: refs/branch-heads/2924@{#710} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/a414b8cea0fcbdb96030ad433a2cf6b7af9e8de8/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
,
Jan 11 2017
verified this issue on Mac 10.12.2 with chrome version #56.0.2924.59 These are the steps i followed 1. Navigated to www.vudu.com 2. Clicked on the view site info and block the flash plugin and reloaded the web page. 3. clicked on the watch trailer for any movie 4. Got the notification in the omnibox with flash plugin. Observed that it didn't display any radio buttons with options allow or continue the blocking plugins and the button which says "Run all plugins this time" Attaching the screenshot and screencast for reference, Could you please look into it and let us know this is the expected behavior for this fix?
,
Jan 11 2017
,
Jan 11 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Dec 14 2016Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)