Regression: Browsing data entries are not getting updated in chrome://md-settings/clearBrowserData untill the page is not refreshed. |
|||||
Issue descriptionChrome Version: 57.0.2950.0/9083.0.0 dev channel Daisy,Peppy,Candy,Mighty OS: Chrome What steps will reproduce the problem? (1)Sign to chrome with valid credentials>> Make some history by navigating to different pages. (2)Navigate to chrome://md-settings/clearBrowserData page>> Here you can see the data related to browser history,Downloads,Cookies,Cache and etc. (3)Click on Clear Browsing Data button and Observe the browser data entries. (Please refer to the video) Expected: Browsing data entries should show none on clearing browsing data. Actual: Instead browsing data entries are not updated until the page is not refreshed. (Please refer to the video) This is regression issue as it is working fine in 56.0.2924.26/9000.26.0 dev-channel paine. Attaching screen-cast for reference.
,
Dec 16 2016
,
Dec 16 2016
Thanks for catching this! I think this was caused by https://codereview.chromium.org/2536003003 where the counter initialization was moved from HandleInitialize() to OnJavaScriptAllowed(). When the dialog is first opened, we run: HandleInitialize() OnJavaScriptAllowed() <-- We should initialize the counters here. On subsequent openings, we only run: HandleInitialize() <-- We should initialize the counters here. I'll fix this shortly.
,
Dec 16 2016
,
Jan 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0eb377ef00cb7afd8392ff44f6ab94b7848b359f commit 0eb377ef00cb7afd8392ff44f6ab94b7848b359f Author: msramek <msramek@chromium.org> Date: Mon Jan 09 21:09:24 2017 Restart counters when the MD CBD dialog is reopened. We call Restart() on all counters in HandleInitialize(), which is called every time the dialog is (re)opened. Note that counters are added to ClearBrowsingDataHandler in OnJavascriptAllowed() and removed in OnJavascriptDisallowed(), so we know that if counters exist, JavaScript is allowed. BUG= 674040 Review-Url: https://codereview.chromium.org/2585633003 Cr-Commit-Position: refs/heads/master@{#442344} [modify] https://crrev.com/0eb377ef00cb7afd8392ff44f6ab94b7848b359f/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
,
Jan 9 2017
,
Mar 2 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jbanavatu@chromium.org
, Dec 14 2016