Avoid nested complex MakeUnique calls in service factories. |
|||
Issue descriptionCurrently both ios and non ios factories use nested MakeUnique, which are tricky to parse (it is not immediately clear which arguments belong to the outer MakeUnique and which to the inner one).
,
Feb 7 2017
In the end we decided to move out RemoteSuggestionsFetcher, but leave everything else there.
,
Feb 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a842fb2c97ce7c2e140a2d77d503c1dc6e1a299 commit 5a842fb2c97ce7c2e140a2d77d503c1dc6e1a299 Author: vitaliii <vitaliii@chromium.org> Date: Wed Feb 08 14:50:50 2017 [NTP::Cleanup] Avoid nested complex function calls The RemoteSuggestionsProviderImpl constructor takes a long list of parameters and previously the RemoteSuggestionFetcher (which also takes a lot of parameters) was constructed in line. This was confusing, because one could not easily determine to which MakeUnique given argument belonged to. This CL moves the RemoteSuggestionsFetcher into a local variable to improve readability. BUG= 674033 Review-Url: https://codereview.chromium.org/2671453003 Cr-Commit-Position: refs/heads/master@{#448992} [modify] https://crrev.com/5a842fb2c97ce7c2e140a2d77d503c1dc6e1a299/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/5a842fb2c97ce7c2e140a2d77d503c1dc6e1a299/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
,
Feb 8 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vitaliii@chromium.org
, Jan 31 2017Owner: vitaliii@chromium.org
Status: Started