New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 674015 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 674676
issue 678694



Sign in to add a comment

[Android N] Notifications get bundled together automatically

Reported by ahalder@etouch.net, Dec 14 2016

Issue description

Application Version: 57.0.2951.0
Android Build Number: 
Device: Nexus 9


Steps to reproduce:
1. Launch Chrome > Open a new incognito tab
2. Go to videojs.com and download the video
3. When downloading is in process, re-download the video
4. Observe download notification icons

Observed behavior:
Chrome download notification icon vanishes automatically when re-downloading a file, though downloads stay under notifications tray

Expected behavior:
Chrome download notification icons should stay when downloads are in progress

Frequency: 
<5/5>
 

Comment 1 by ahalder@etouch.net, Dec 14 2016

Correction:
Android Build Number: 7.0/NRD91N

Additional comments:
This issue is present on all the builds of M55, M56 and M57 milestones
This issue is present on Android N devies ex. Nexus 9 (7.0/NRD91N), Google Pixel (7.1/NDE63V), Google Pixel XL (7.1/NDE63V) and LG Nexus 5X (7.0/NRD90R)

Comment 2 by ahalder@etouch.net, Dec 14 2016

Please find logs and Video @ http://go/chrome-androidlogs1/6/674015
Components: UI>Browser>Downloads
Labels: -Pri-3 M-56 Pri-2 Type-Bug
Owner: dfalcant...@chromium.org
Status: Assigned (was: Unconfirmed)
Owner: qin...@chromium.org
Status: WontFix (was: Assigned)
Looks like what N's automatically grouping notifications.  Guessing that's a feature.
Cc: dim...@chromium.org tedc...@chromium.org hannahs@chromium.org bever...@google.com qin...@chromium.org dfalcant...@chromium.org
Owner: ----
Status: Available (was: WontFix)
Summary: [Android N] Notifications get bundled together automatically (was: [Android N] Chrome download notification icon vanishes automatically when re-downloading a file from Incognito mode)
Actually, going to reopen this but make it more general.

https://android-developers.googleblog.com/2016/06/notifications-in-android-n.html

Unless you manually bundle your notifications, Android N will collapse them all together and pick a random icon for it.  This is suboptimal because a bunch of icons will end up behind an Incognito icon (e.g. in the video for comment #2).  There's probably a better way to handle this than letting Android do what it wants.

+ CC'ing folks who have dealt with notifications or might have to deal with notifications in the future
Cc: -bever...@google.com peter@chromium.org
Cc: mlamouri@chromium.org cco3@chromium.org avayvod@chromium.org
+ Adding Media notifications and Physical Web to the notification party
Cc: zea@chromium.org
+ Adding sync peeps.
( //chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java )

Comment 9 by ahalder@etouch.net, Dec 15 2016

A quick update, if we perform the same set of steps in non-incognito mode, the download notification icon stays and works as the aforementioned expected result

Comment 10 by peter@chromium.org, Dec 15 2016

Cc: awdf@chromium.org
Components: UI>Notifications
Labels: -Restrict-View-Google
Let's make this public.

The issue is targeted for M-56 — while the fixes will be small, non-controversial and safe, Beta's already released so we should consider punting given that the population on N is still rather small.
Re #9:
They start bundling at 4, so if you're still at 3 (without the incognito icon) you're good.
Cc: dtrainor@chromium.org
Labels: -M-56 M-57
Blockedon: 674676

Comment 14 by awdf@chromium.org, Dec 16 2016

Blockedon: 674927
Cc: shaktisahu@chromium.org
+shaktisahu@
Blockedon: 678694
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/318c5ae5cb37a664c2f068fa2095d293bfc50bcd

commit 318c5ae5cb37a664c2f068fa2095d293bfc50bcd
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Jan 06 20:03:57 2017

Group Downloads notifications, and separate Incognito

* Download notifications are grouped together, and Incognito
  is put into its own group.  Summary notifications will come
  in a later patch; Android N doesn't seem to bundle these
  together once they're in their own group, making it hard
  to debug without Android Wear.

* New and existing group name constants are moved into
  NotificationConstants.java.

* Cleans up DownloadNotificationService's constant naming
  schemes to make it clearer what each field does.

BUG=678694, 674015 

Review-Url: https://codereview.chromium.org/2619433003
Cr-Commit-Position: refs/heads/master@{#442017}

[modify] https://crrev.com/318c5ae5cb37a664c2f068fa2095d293bfc50bcd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/318c5ae5cb37a664c2f068fa2095d293bfc50bcd/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java
[modify] https://crrev.com/318c5ae5cb37a664c2f068fa2095d293bfc50bcd/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/318c5ae5cb37a664c2f068fa2095d293bfc50bcd/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/318c5ae5cb37a664c2f068fa2095d293bfc50bcd/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Components: -UI>Browser>Downloads
Removing downloads component because it was being tracked by 678694.
Incognito, downloads, and media notifications are all currently assigned a different group and don't get grouped together.  Haven't seen any CLs for the other kinds of notifications.

Comment 20 by awdf@chromium.org, Jan 11 2017

I just uploaded https://codereview.chromium.org/2628723003/ for push notifications - there's also one in progress for sync notifications by peter@
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e424e1f96c68e959d2980c2f50ac3cee6a50dde9

commit e424e1f96c68e959d2980c2f50ac3cee6a50dde9
Author: awdf <awdf@chromium.org>
Date: Thu Jan 12 17:55:27 2017

Android notifications: set group for push notifications

- Push notifications are no longer grouped with all other Chrome
  notifications

- However, this patch makes them standalone, rather than grouped by
  origin, as we aren't yet setting a summary notification.

BUG= 674015 ,674335

Review-Url: https://codereview.chromium.org/2628723003
Cr-Commit-Position: refs/heads/master@{#443285}

[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java
[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilderTest.java
[modify] https://crrev.com/e424e1f96c68e959d2980c2f50ac3cee6a50dde9/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java

Comment 22 by awdf@chromium.org, Jan 17 2017

Blockedon: -674927

Comment 23 Deleted

Comment 24 Deleted

Comment 25 by ahalder@etouch.net, Jan 31 2017

This issue is fixed on latest M57 Thanks!
Status: Verified (was: Available)

Sign in to add a comment