New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 674001 link

Starred by 1 user
Status: Fixed
Owner:
sadrul@chromium.org
Closed: Jan 2017
Cc:
danakj@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
piman@chromium.org
enne@chromium.org
sky@chromium.org
█ jbau...@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mash_unittests seems to be using InProcessContextFactory instead of Suface/MusContextFactory

Project Member Reported by fsam...@chromium.org, Dec 14 2016 
We should be using SurfaceContextFactory or MusContextFactory in mash. This doesn't yet seem to be the case. We should fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27

commit a2fd53c7b0a8b9f0c657e94257059879c8fe7a27
Author: sadrul <sadrul@chromium.org>
Date: Fri Jan 20 00:53:43 2017

mash: Do not use InProcessContextFactory in tests.

InProcessContextFactory provides both ContextFactory and ContextFactoryPrivate
implementations. The latter should not be needed in the mus-client side. And
the ContextFactory implementation in InProcessContextFactory also directly
talks to the display compositor (e.g. uses SurfaceManager). So avoid using it
in mash_unittests, and instead, create a DummyContextFactory that doesn't do
much.

BUG= 674001 

Review-Url: https://codereview.chromium.org/2639513002
Cr-Commit-Position: refs/heads/master@{#444900}

[modify] https://crrev.com/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27/mash/BUILD.gn
[add] https://crrev.com/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27/mash/test/DEPS
[modify] https://crrev.com/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27/mash/test/mash_test_suite.cc
[modify] https://crrev.com/a2fd53c7b0a8b9f0c657e94257059879c8fe7a27/mash/test/mash_test_suite.h

Comment 2 by fsam...@chromium.org, Jan 22 2017

Owner: sadrul@chromium.org
Status: Started (was: Untriaged)
Can we now mark this as FIXED?

Comment 3 by sadrul@chromium.org, Jan 22 2017

Status: Fixed (was: Started)

Comment 4 by fsam...@chromium.org, Jun 13 2017

Blocking: -601863
►

Sign in to add a comment