Forgot to mention, that error window I saw was after I clicked the "Sign in" button.

[Mac Triage] Assigning to ewald@ for further triage.

Moe, you recently updated these settings error messages on desktop, right? In the auth error case, shouldn't clicking "Sign in" just bring up the modal sign in dialogue? Why is it trying to sign Nicolas out first?

IIRC, we have to "Sign out and sign back in again" on CrOS, but on desktop we should be able to just re-auth the user.

I don't remember the reason why we couldn't just reauthenticate the user. We eventually decided to "silently" sign the user out and sign them back in. md-settings handles the case of managed accounts gracefully (without deleting the profile)
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.js?l=310

There must've been an oversight in the old settings page when implementing it. zea@ could you try fixing the sync error in chrome://md-settings and see if it works?

I recall that we decided to silently sign the user out and sign them back in again for "UNRECOVERABLE_ERROR"s, but for regular auth errors I thought we could just display the re-auth page.

What eventually worked for me was clicking "advanced sync settings", which then oddly enough prompted me to sign in again (had to re-enter password). Things worked from then on.

Hmmmm alright. Moe, re-assigning to you. Can you double check to make sure that for regular auth errors, we're not silently signing out/back in again? We should only be doing that on CrOS for auth errors, or for unrecoverable errors.

In response to comment #5, you're correct. I wasn't differentiating between UNRECOVERABLE_ERROR and AUTH_ERROR. I have fix up for review.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2280c8fda1618773a1d572a8abd2663b754cd486

commit 2280c8fda1618773a1d572a8abd2663b754cd486
Author: mahmadi <mahmadi@chromium.org>
Date: Thu Dec 22 14:16:14 2016

[MD Settings][People] Force sign out only in the case of unrecoverable error

BUG= 674000 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2591093002
Cr-Commit-Position: refs/heads/master@{#440410}

[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/sync/sync_ui_util.h
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/2280c8fda1618773a1d572a8abd2663b754cd486/chrome/browser/ui/webui/settings/people_handler_unittest.cc

Can we mark this as Fixed, Moe?

Verified it works on canary 57.0.2970.0
Marking as fixed and adding Merge-Request-56

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d661228218c77361177eeffb20466fd1ccbc74d

commit 9d661228218c77361177eeffb20466fd1ccbc74d
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Tue Jan 03 19:58:37 2017

[MD Settings][People] Force sign out only in the case of unrecoverable error

BUG= 674000 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2591093002
Cr-Commit-Position: refs/heads/master@{#440410}
(cherry picked from commit 2280c8fda1618773a1d572a8abd2663b754cd486)

Review-Url: https://codereview.chromium.org/2603283003 .
Cr-Commit-Position: refs/branch-heads/2924@{#653}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/sync/sync_ui_util.h
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/ui/webui/settings/people_handler.h
[modify] https://crrev.com/9d661228218c77361177eeffb20466fd1ccbc74d/chrome/browser/ui/webui/settings/people_handler_unittest.cc

Tested this issue on Mac 10.12.2 using chrome beta version #56.0.2924.51

The steps followed to test this issue are as follows:
-------------
1. Launched chrome and signed into chrome.
2. Navigated to chrome://settings and clicked on the "Google dashboard" link present in the "sign in" section.
3. Scrolled down and clicked on the "reset sync" button.
4. Again navigated to chrome://settings and signed in again.
5. Observed that the 2nd time sign in was successful.

Attaching screen cast for reference.

mahmadi@ - Could you please verify the screen cast and please let us know if it is the expected behavior.

Thanks...!!

Deleted: 674000.mp4 2.5 MB

	674000.mp4 2.5 MB View Download

The correct steps for reproducing the issue are as follows:

1. Launch chrome and sign into chrome using a managed account (e.g., @google.com)
2. Create an auth error (easiest way would be to remove Chrome's access token in https://myaccount.google.com/permissions?pli=1)
3. Wait until Chrome realizes the auth error.
4. Proceed with authenticating again.

Expected result: authentication should happen successfully without requiring the user to delete their profile first.
Note: Please verify this works in both chrome://settings and chrome://md-settings

Verified the fix on Mac 10.12.2 using Chrome Beta version #56.0.2924.51 as per the comment #15.

Observed that authentication happened successfully without requiring the user to delete their profile first as expected.

Note: Tested in both chrome://settings and chrome://md-settings

Hence, the fix is working as expected.

Attaching the screencast for reference.

Adding the verified labels.

Deleted: 674000.mp4 1.8 MB

	674000.mp4 1.8 MB View Download